Fix GH-18422: int overflow in php_date_llabs#21638
Closed
iliaal wants to merge 2 commits into
Closed
Conversation
iluuu1994
reviewed
Apr 4, 2026
iliaal
force-pushed
the
fix/gh-18422-date-llabs-overflow
branch
2 times, most recently
from
de9d934 to
2f19e2f
Compare
iluuu1994
approved these changes
Apr 4, 2026
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
LGTM, but Derick is codeowner.
iliaal
force-pushed
the
fix/gh-18422-date-llabs-overflow
branch
from
2f19e2f to
6bdb3cb
Compare
iliaal
force-pushed
the
fix/gh-18422-date-llabs-overflow
branch
2 times, most recently
from
eae5780 to
50aaf05
Compare
Year arithmetic in timelib (tm2unixtime) overflows int64_t under extreme inputs such as PHP_INT_MIN years. The result is undefined behavior detected by UBSan. Compile ext/date with -fwrapv so the wrap is well-defined.
php_date_llabs negated its argument with -i, which is UB when i is LLONG_MIN. Cast to uint64_t before negating and use stdint types throughout. Updated Y/x/X format call sites to PRIu64. Closes phpGH-18422
iliaal
force-pushed
the
fix/gh-18422-date-llabs-overflow
branch
from
50aaf05 to
134769d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php_date_llabsnegates with-i, which is UB wheniisLLONG_MIN. Cast tounsigned long longbefore negating and changed the return type to match. Updated Y/x/X format call sites from%lldto%llu.Fixes #18422