Set curl post size using CURLOPT_POSTFIELDSIZE_LARGE#22842
Draft
Sjord wants to merge 2 commits into
Draft
Conversation
This is a 64-bit number on all platforms. This improves support of posting files larger than 2GB. - https://curl.se/libcurl/c/CURLOPT_POSTFIELDSIZE.html - https://curl.se/libcurl/c/CURLOPT_POSTFIELDSIZE_LARGE.html
devnexen
reviewed
Jul 21, 2026
| zend_string *str = zval_get_tmp_string(zvalue, &tmp_str); | ||
| /* with curl 7.17.0 and later, we can use COPYPOSTFIELDS, but we have to provide size before */ | ||
| error = curl_easy_setopt(ch->cp, CURLOPT_POSTFIELDSIZE, ZSTR_LEN(str)); | ||
| error = curl_easy_setopt(ch->cp, CURLOPT_POSTFIELDSIZE_LARGE, ZSTR_LEN(str)); |
Member
There was a problem hiding this comment.
looking good you really do need the curl_off_t cast albeit size_t is unsigned and curl_off_t is not but we re safe as far as overflow goes (for now at least :)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 64-bit number on all platforms. This improves support of posting files larger than 2GB.