Eliminate globals for $RELASES / $OLDRELEASES / $BRANCHES#1931
Open
markrandall wants to merge 1 commit into
Open
Eliminate globals for $RELASES / $OLDRELEASES / $BRANCHES#1931markrandall wants to merge 1 commit into
markrandall wants to merge 1 commit into
Conversation
markrandall
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
derickr
reviewed
Jun 18, 2026
| static $cache = null; | ||
|
|
||
| /* there is no normalisation required here because it's all standard format */ | ||
| return $cache ??= require __DIR__ . '/../../include/version.inc'; |
Member
There was a problem hiding this comment.
I wonder whether this "caching" is needed, considering the return happens straight from an opcache-cached oparray.
Author
There was a problem hiding this comment.
version.inc is the one for the most recent releases - as such it's optimized for updating hashes, and and uses an IIFE each time it is included to format the data into the normalized form.
| { | ||
| static $cache = null; | ||
| return $cache ??= (function () { | ||
| $results = []; |
Member
There was a problem hiding this comment.
same here, and the use of a closure seems odd to just wrap around a single return value, without it being reused.
Author
There was a problem hiding this comment.
I find the style personally cleaner than a big if block or double return points.
| public static function getBranchOverrides(): array | ||
| { | ||
| static $cache = null; | ||
| return $cache ??= require __DIR__ . '/../../include/branch-overrides.inc'; |
markrandall
force-pushed
the
branch-api-extraction
branch
from
5bc2ef7 to
4660988
Compare
…thout having to rely on global-scoped variables.
markrandall
force-pushed
the
branch-api-extraction
branch
from
4660988 to
a416b4d
Compare
markrandall
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to eliminate the dependence on the $RELEASES, $OLDRELEASES, and $BRANCHES global variables that require injecting in at the top level scope to avoid breaking things.
Changes:
Included: