Skip to content

Conversation

@simPod
Copy link
Contributor

@simPod simPod commented Dec 17, 2025

No description provided.

@andrew-demb
Copy link

@simPod There are no changes to composer.json in commit.

@simPod
Copy link
Contributor Author

simPod commented Dec 17, 2025

I was tinkering with CI and accidentally removed the change. Fixed, thx.

@Chris53897
Copy link

Could you please change the types like suggested by Psalm?
https://github.com/phpDocumentor/ReflectionDocBlock/blob/5.x/src/Utils.php#L58

@simPod
Copy link
Contributor Author

simPod commented Dec 22, 2025

I've cleaned up the composer.lock change. It should not be committed in the library repo so I'll try not to touch it.

@Chris53897
Copy link

@simPod
Copy link
Contributor Author

simPod commented Dec 22, 2025

I know but the point is that it is not relevant to this change. The psalm issue is on master as well right now.

Currently psalm check passes on this commit, same as it does on master https://github.com/simPod/ReflectionDocBlock/actions/runs/20441409379/job/58735043783

@jaapio
Copy link
Member

jaapio commented Dec 22, 2025

It could be the psalm error is triggered by a change in webmozart/assert. I see @Chris53897 created a new PR.
CI is running on both now.

@jaapio jaapio merged commit 5cee1d3 into phpDocumentor:5.x Dec 22, 2025
49 checks passed
@jaapio
Copy link
Member

jaapio commented Dec 22, 2025

I don't know why CI did not pass at the first run, it's now ok. So merged this.

Thanks for your help!

@Chris53897
Copy link

Thanks @simPod @jaapio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants