Setup mutation testing - #4480
Conversation
|
AFAIK the usage of build-infection isn't yet merged in phpstan-doctrine? I'd finish it there first before doing other repos. |
yes, its waiting in phpstan/phpstan-doctrine#699 for the merge. |
|
This pull request has been marked as ready for review. |
| mutation-testing: | ||
| name: "Mutation Testing" | ||
| runs-on: "ubuntu-latest" | ||
| needs: ["tests", "tests-levels"] |
There was a problem hiding this comment.
tests-levels? I don't want Infection to run these levels so it doesn't make sense to wait for them.
There was a problem hiding this comment.
Also: what about static analysis? I know it's in another workflow but not warmed-up cache might have a downside or two here?
There was a problem hiding this comment.
tests-levels? I don't want Infection to run these levels so it doesn't make sense to wait for them.
I initially added levels to make sure we run late enough for the static analysis step... does no longer make sense as we no longer have the artifact down/upload step.
deleted it.
Also: what about static analysis? I know it's in another workflow but not warmed-up cache might have a downside or two here?
as we restore the previous cache I think it will be "fresh enough". waiting across workflows will complicate it, as this is only supported in github actions with work-arrounds. I don't think its worth the effort.
infection will start and fail in the "preparation phase" when SA is not green.
There was a problem hiding this comment.
I thought we could just run PHPStan again before Infection.
There was a problem hiding this comment.
infection will run it once before it starts it as a process killer
| cat infection.json5 | jq | ||
|
|
||
| - name: "Cache Result cache" | ||
| uses: actions/cache@v4 |
There was a problem hiding this comment.
This isn't going to save the cache if the build fails, right? Shouldn't we do what's recommended here? https://phpstan.org/user-guide/result-cache#setup-in-github-actions
|
Thank you! I'm really interested what it will find here 😊 |
I will check with the infection team in infection/infection#2491 :) |
|
ok future PRs to phpstan-src will now have infection coverage, see a first e2e running build in e.g. https://github.com/phpstan/phpstan-src/actions/runs/18841268167/job/53754293666?pr=4470 //cc @maks-rafalko |
|
Cool! Thanks for working on this @staabm and @ondrejmirtes. Looking forward to hear the results after some time. So please share them somewhere |
analog