Merged
Conversation
The nugetlock parser is theoretically better, but many clients have found that the nugetlock lockfile generation does not work without a very specific environment because of the complexity of the build system... This patch is an effort to work in more scenarios by switching the default parser to msbuild
kylewillmon
force-pushed
the
csproj-best-effort
branch
from
b8fdc9e to
3c8aecc
Compare
maxrake
approved these changes
Jun 3, 2024
Contributor
maxrake
left a comment
maxrake
left a comment
There was a problem hiding this comment.
This was (somewhat) tested locally. It was hard to replicate the same results as would be found in CI with a linux/amd64 platform Docker image running on a macOS system. The changes in this PR are minimal and review of the code that determines which parser and/or generator will be used led me to believe the changes here are correct. There is a small question about whether the documentation will need to be updated based on this change...particularly the lockfile generation page. Approving now to get a solution out there and the docs can be updated later, if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nugetlock parser is theoretically better, but many clients have found that the nugetlock lockfile generation does not work without a very specific environment because of the complexity of the build system...
This patch is an effort to work in more scenarios by switching the default parser to msbuild