Skip to content

Ensure pietestgui is installed - #7

Merged
michaelhatPIengineering merged 4 commits into
piengineering:masterfrom
cwilling:gui-executable
Apr 9, 2021
Merged

Ensure pietestgui is installed#7
michaelhatPIengineering merged 4 commits into
piengineering:masterfrom
cwilling:gui-executable

Conversation

@cwilling

@cwilling cwilling commented Apr 8, 2021

Copy link
Copy Markdown
Contributor

Signed-off-by: Christoph Willing chris.willing@linux.com

Signed-off-by: Christoph Willing <chris.willing@linux.com>
@cwilling

cwilling commented Apr 8, 2021

Copy link
Copy Markdown
Contributor Author

The current 'configure/make/make install' omits installing pietestgui. This PR adds pietestgui to the installation list.

@cwilling cwilling mentioned this pull request Apr 8, 2021
@michaelhatPIengineering

Copy link
Copy Markdown
Contributor

I would be happy to merge this but there are conflicts.

<<<<<<< gui-executable
TARGET_LINK_LIBRARIES(pietestgui
Qt5::Core
Qt5::Gui
Qt5::Widgets
piehid
)

INSTALL(TARGETS pietestgui
RUNTIME DESTINATION bin
)

INSTALL(FILES pietestgui.desktop DESTINATION share/applications)

master

how to I resolve them so I can merge?

Sorry, my life is usually at the USB byte level, where my only task is to manage 36 bytes.

Michael

@cwilling

cwilling commented Apr 9, 2021

Copy link
Copy Markdown
Contributor Author

I'm not sure but it may be because #9 was applied before #7. I'll reload what's in the repo right now and make a new PR. Leave this one as it is - I think I can make the changes in place. If not, I'll just submit a new PR.

@michaelhatPIengineering

michaelhatPIengineering commented Apr 9, 2021 via email

Copy link
Copy Markdown
Contributor

cwilling added 3 commits April 9, 2021 23:23
Signed-off-by: Christoph Willing <chris.willing@linux.com>
Signed-off-by: Christoph Willing <chris.willing@linux.com>
@cwilling

cwilling commented Apr 9, 2021

Copy link
Copy Markdown
Contributor Author

Actually, it wasn't the ordering. It was because I made changes to the same file in different PRs, so my mistake.

I've fixed it now so should be OK to merge.

@michaelhatPIengineering
michaelhatPIengineering merged commit 6d63cee into piengineering:master Apr 9, 2021
@cwilling
cwilling deleted the gui-executable branch April 9, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants