docs(diffs): Document editable line annotations - #1003
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
73da2ee to
8238e44
Compare
Explain how applications retain remapped annotations across standalone editors and CodeView, including React and vanilla ownership patterns. Add typed examples for file and diff annotations, document deletion and virtualization behavior, and lock final-line deletion semantics with focused regression tests.
Edit a standalone file with annotations: onChange delivers side-less LineAnnotation entries, but its public type only allowed DiffLineAnnotation. CodeView exposed the same mismatch for file items. Accept the two homogeneous annotation collections throughout Editor and CodeView, export guards for narrowing them, and update examples and tests to preserve remapped annotations for either item type.
8238e44 to
d7c476d
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7c476d16c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
* docs(diffs): Document editable line annotations Explain how applications retain remapped annotations across standalone editors and CodeView, including React and vanilla ownership patterns. Add typed examples for file and diff annotations, document deletion and virtualization behavior, and lock final-line deletion semantics with focused regression tests. * fix(diffs): Type edit callbacks for file annotations Edit a standalone file with annotations: onChange delivers side-less LineAnnotation entries, but its public type only allowed DiffLineAnnotation. CodeView exposed the same mismatch for file items. Accept the two homogeneous annotation collections throughout Editor and CodeView, export guards for narrowing them, and update examples and tests to preserve remapped annotations for either item type. * PR Review Fixes
1 participant
Most a bunch of additional docs for how to handle line annotations when editing.
LineAnnotation[]andDiffLineAnnotation[].DiffLineAnnotation[]which was technically not accurate