Expose internal imperative navigation API as a public API - #1020
Merged
Conversation
Host controls can now move focus through the visible tree and inspect the same row order that Trees renders. This keeps custom navigation in sync with expansion, search, sorting, and flattened directories. Forward the existing controller navigation and visible-row methods through the public FileTree model, add direct model coverage, and document the API for React and vanilla users.
Expose public FileTree navigation APIs
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
@K-Mistele is attempting to deploy a commit to the Pierre Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exposes the private imperative navigation API in Pierre's Trees library as a public API.
Motivation & Context
Pierre's Diffs library has a public imperative navigation API. This is very useful for building keyboard- and hotkey-first experiences on the Diff library.
While integrating the Trees library into HumanLayer, I noticed that unlike the Diffs library, the Trees library's imperative navigation API is internal/private.
This PR makes that private API Public.
Type of changes
first discussed with the dev team and they should be aware that this PR is
being opened
You must have first discussed with the dev team and they should be aware
that this PR is being opened
Checklist
contributing guidelines
moon run root:lint)moon run root:format)moonx diffs:test)How was AI used in generating this PR
-> received feedback from @SlexAxton