[diffs/edit] Reworking Naming Conventions#1023
Merged
Merged
Conversation
Expose the optional editing runtime from @pierre/diffs/edit so consumers can lazy-load the Edit feature without using an implementation name. Move the public barrel out of the internal editor directory and migrate package exports, in-repo consumers, docs snippets, and browser fixtures.
Rename the creation-time React prop from editOptions to editorOptions so edit remains the feature switch and Editor names the configured runtime. Carry the new name through every surface, CodeView lifecycle coverage, demos, documentation, and generated examples.
Rename feature-owned docs sections, demo components, constants, shortcuts, and navigation metadata from Editor to Edit while preserving the runtime Editor API terminology. Move the documentation source directory to Edit, consolidate the Live Editing example assets, and update the LLM text generator so generated navigation follows the feature name.
Remove the unused didEdit render prop and name session comments after the Edit feature. Align test labels with the EditStack class and the current keyboard command resolver.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
amadeus
marked this pull request as ready for review
July 23, 2026 22:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR officially makes the feature called
edit, but keeps concepts like the class stillEditor.This changes the module's entry point, and fixes a bunch of contextually necessary stuff to be
editoreditorbased on convention.