Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 608a1a3434
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| topScreen = Math.max(topScreen, codeRect.top); | ||
| bottomScreen = Math.min(bottomScreen, codeRect.bottom); |
There was a problem hiding this comment.
Invalidate cached code rect when code height changes
Because getPlacementBounds() now clamps to codeRect.bottom, the cached [data-code] rect's height directly controls placement. That rect is only dirtied when setViewportElements() sees a different code element and on scroll/resize; normal edits can append/remove rows in the existing code element, so after inserting or deleting lines the manager can keep the old bottom until the user scrolls or resizes. In that state first/last-line selection-action or marker popovers can flip against a stale clip edge and still be clipped, or flip unnecessarily.
Useful? React with 👍 / 👎.
|
@ije Could use your eyes on the source changes here, please. |
fix issue with selection action, add another selection action for edges
Follow up to #927.