Skip to content

Updated Playwright tests, modify edit mode popover flipping - #957

Merged
mdo merged 1 commit into
beta-1.3from
mdo/pw-v2
Jul 14, 2026
Merged

Updated Playwright tests, modify edit mode popover flipping#957
mdo merged 1 commit into
beta-1.3from
mdo/pw-v2

Conversation

@mdo

@mdo mdo commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Follow up to #927.

  • Refines selection action test
  • Adds another selection action test to confirm flipping behaviors
  • Modifies popover flipping detection for instances where short files cause placement issues

@mdo
mdo requested review from ije and necolas July 9, 2026 22:18
@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pierre-docs-diffs Ready Ready Preview Jul 9, 2026 10:18pm
pierre-docs-diffshub Ready Ready Preview Jul 9, 2026 10:18pm
pierre-docs-trees Ready Ready Preview Jul 9, 2026 10:18pm
pierrejs-diff-demo Ready Ready Preview Jul 9, 2026 10:18pm

Request Review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 608a1a3434

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +156 to +157
topScreen = Math.max(topScreen, codeRect.top);
bottomScreen = Math.min(bottomScreen, codeRect.bottom);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Invalidate cached code rect when code height changes

Because getPlacementBounds() now clamps to codeRect.bottom, the cached [data-code] rect's height directly controls placement. That rect is only dirtied when setViewportElements() sees a different code element and on scroll/resize; normal edits can append/remove rows in the existing code element, so after inserting or deleting lines the manager can keep the old bottom until the user scrolls or resizes. In that state first/last-line selection-action or marker popovers can flip against a stale clip edge and still be clipped, or flip unnecessarily.

Useful? React with 👍 / 👎.

@mdo

mdo commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@ije Could use your eyes on the source changes here, please.

@ije ije left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mdo
mdo merged commit 2539bb2 into beta-1.3 Jul 14, 2026
8 checks passed
@mdo
mdo deleted the mdo/pw-v2 branch July 14, 2026 20:36
amadeus pushed a commit that referenced this pull request Jul 21, 2026
fix issue with selection action, add another selection action for edges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants