Skip to content

[diffs/edit] Fix the CRLF position round-trip bug - #993

Merged
ije merged 2 commits into
beta-1.3from
ije/fix-round-trip
Jul 15, 2026
Merged

[diffs/edit] Fix the CRLF position round-trip bug#993
ije merged 2 commits into
beta-1.3from
ije/fix-round-trip

Conversation

@ije

@ije ije commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Position round-trip losing a column (1) — a position-from-offset
computation can return a position strictly inside a CRLF pair (a character
beyond the line's own length) that the inverse offset-from-position
computation clamps away, so the round trip silently loses a column.

Normalized both positionAt and positionsAt outputs.

@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pierre-docs-diffs Ready Ready Preview Jul 15, 2026 4:34pm
pierre-docs-diffshub Ready Ready Preview Jul 15, 2026 4:34pm
pierre-docs-trees Ready Ready Preview Jul 15, 2026 4:34pm
pierrejs-diff-demo Ready Ready Preview Jul 15, 2026 4:34pm

Request Review

@ije
ije requested review from amadeus, fat and necolas July 15, 2026 14:06
@ije

ije commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 905618644e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants