Add cookies.remove(name[, options]) method#98
Add cookies.remove(name[, options]) method#98smcmurray wants to merge 4 commits intopillarjs:masterfrom smcmurray:patch-3
Conversation
An easy way to expire a cookie.
dougwilson
left a comment
There was a problem hiding this comment.
This seems like a good idea to me. Looks like Travis CI says there is a syntax error with the code, if you can take a look. Also please add tests for the new feature when you get a chance!
|
I think it doesn't like the options argument default. |
|
Hi @smcmurray unless it is impossible to implement without new versions, then we want to support. If it's impossible to implement your feature on old Node.js versions, then we can hold the PR for sometime in the future in which we no longer support them 👍 |
|
I'm not sure how to build a test with new cookies(). |
|
Hi @smcmurray it's no problem. We have many tests using |
An easy way to expire a cookie.