fix(cosift): wrap Pebble Close in sync.Once for idempotency (closes PILOT-190)#4
Merged
Merged
Conversation
cockroachdb/pebble's *DB.Close() panics if invoked twice. PebbleStore passed the call through unprotected, so layered cleanups (e.g. t.Cleanup + explicit defer, signal handler + main exit) could panic the process at shutdown. Wrap teardown in sync.Once and cache the first-call error in closeErr so every caller sees the same outcome. Adds TestPebbleStore_CloseIsIdempotent as a regression — opens a store, calls Close() three times, asserts no panic and a stable return value. Closes PILOT-190.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cockroachdb/pebble's*DB.Close()panics if called twice;PebbleStore.Close()passed the call through unprotected, so any layered cleanup (e.g.t.Cleanup+ explicitdefer, signal handler + main exit) could panic at shutdowncloseOnce sync.Once+closeErr errorfields toPebbleStoreand wrap the Pebble close incloseOnce.Do(...), caching and returningcloseErrso every caller sees the same outcomeServer.Closein PILOT-182Files
internal/store/pebble.go— struct fields +Close()rewriteinternal/store/pebble_test.go—TestPebbleStore_CloseIsIdempotentregression test (3 calls, assert no panic + stable return)Test plan
go build ./...— cleango test -race -count=3 -timeout 120s ./...— all packages pass 3xgo test -race -count=3 -run TestPebbleStore_CloseIsIdempotent ./internal/store/...— greenCloses PILOT-190.