fix: wrap L1 caches in bounded LRU to prevent unbounded memory growth (PILOT-106)#7
Merged
Merged
Conversation
… (PILOT-106) Replace unbounded map[string]... caches in paraphraser and hydePassager with a generic, thread-safe lruCache that enforces a hard 10,000-entry cap. LRU eviction prevents monotonic memory growth from unique queries. - New file: internal/server/lru.go — generic LRU with optional TTL - paraphraser: map[string][]string → lruCache[[]string], cap 10k - hydePassager: map[string]string → lruCache[string], cap 10k - Removes sync.Mutex from both structs (LRU handles its own locking) Fixes PILOT-106.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the unbounded
map[string]...L1 caches in both the paraphraser and hydePassager with a generic, thread-safelruCachethat enforces a hard 10,000-entry cap.Why (PILOT-106)
The paraphraser cache (
http.go) and HyDE passage cache (hyde.go) had no eviction, TTL, or size cap. Unique query strings kept adding entries forever, causing monotonic memory growth until OOM. An attacker could accelerate this by sending randomized queries.Changes
internal/server/lru.golruCache[V]with internal mutex, LRU eviction, and optional per-entry TTL support.internal/server/http.gomap[string][]string→lruCache[[]string], cap 10k. Removedsync.Mutex(LRU handles its own). Removed unusedsyncimport.internal/server/hyde.gomap[string]string→lruCache[string], cap 10k. Removedsync.Mutex+ unusedsyncimport.Testing
go build ./...✅go test ./...✅ (9/9 packages pass)