fix: add per-beacon-ID cooldown to HandleBeaconRegister (PILOT-331)#13
Merged
Conversation
HandleBeaconRegister now enforces a BeaconRegisterCooldown (10s) per beacon ID. A beacon that re-registers within the cooldown window receives an error instead of silently overwriting the entry. This prevents an attacker (even with admin-token access) from churning through distinct beacon IDs faster than one per cooldown window. - routing/routing.go: add BeaconRegisterCooldown constant; check in HandleBeaconRegister before allowing re-register - routing/zz_routing_test.go: TestBeaconRegisterCooldown verifies immediate re-register is denied, post-cooldown succeeds, and different beacon IDs are not affected
matthew-pilot
added
the
matthew-fix-larger
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HandleBeaconRegister now enforces a BeaconRegisterCooldown (10s) per beacon ID. A beacon that re-registers within the cooldown window receives an error instead of silently overwriting the entry. This prevents an attacker (even with admin-token access) from churning through distinct beacon IDs faster than one per cooldown window.
Changes
routing/routing.go: addBeaconRegisterCooldownconstant; check inHandleBeaconRegisterbefore allowing re-registerrouting/zz_routing_test.go:TestBeaconRegisterCooldownverifies immediate re-register is denied, post-cooldown succeeds, and different beacon IDs are not affectedScope
2 files, +69/-1 (70 LoC)
Testing
go build ./...✅go vet ./...✅go test ./routing/ -v -count=1✅ (all 10 tests pass, including new TestBeaconRegisterCooldown)Jira
PILOT-331