Skip to content

fix: tighten standby read deadline and heartbeat interval (PILOT-281) #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthew-pilot wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix: tighten standby read deadline and heartbeat interval (PILOT-281) #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion replication.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ func (s *Server) standbySession(primaryAddr string) error {
default:
}

conn.SetReadDeadline(time.Now().Add(45 * time.Second)) //nolint:errcheck
conn.SetReadDeadline(time.Now().Add(30 * time.Second)) //nolint:errcheck
msg, err := readMessage(conn)
if err != nil {
if err == io.EOF {
Expand Down
2 changes: 1 addition & 1 deletion replication/replication.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ func (m *Manager) PushDelta(entries []walpkg.DeltaEntry, seqNo uint64) {
// subscribers so standbys can detect primary failure within ~30s.
// It blocks until done is closed.
func (m *Manager) StartHeartbeat(done <-chan struct{}) {
ticker := time.NewTicker(15 * time.Second)
ticker := time.NewTicker(10 * time.Second)
defer ticker.Stop()
for {
select {
Expand Down
Loading