Skip to content

fix(webhook): add dlq_dropped metric + warn on DLQ ring eviction (PILOT-313) #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthew-pilot wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −11
Open

fix(webhook): add dlq_dropped metric + warn on DLQ ring eviction (PILOT-313) #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions webhook/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,10 @@ type dispatcher struct {
secret string // HMAC-SHA256 pre-shared secret (empty = no sig)

// Dead letter queue: stores last N failed events for retry/inspection
dlqMu sync.Mutex
dlqItems []*Event
dlqMax int
dlqMu sync.Mutex
dlqItems []*Event
dlqMax int
dlqDropped atomic.Uint64 // events evicted from DLQ ring
}

const (
Expand Down Expand Up @@ -199,6 +200,8 @@ func (d *dispatcher) addToDLQ(ev *Event) {
defer d.dlqMu.Unlock()
if len(d.dlqItems) >= d.dlqMax {
d.dlqItems = d.dlqItems[1:] // drop oldest
d.dlqDropped.Add(1)
slog.Warn("registry webhook DLQ full, dropping oldest event", "dlq_max", d.dlqMax)
}
d.dlqItems = append(d.dlqItems, ev)
}
Expand Down Expand Up @@ -360,21 +363,23 @@ func (st *Store) HandleGetWebhook() map[string]interface{} {
st.mu.RUnlock()

url := ""
var delivered, failed, dropped uint64
var delivered, failed, dropped, dlqDropped uint64
dlqLen := 0
if d != nil {
url = d.url
delivered, failed, dropped = d.stats()
dlqDropped = d.dlqDropped.Load()
dlqLen = len(d.getDLQ())
}
return map[string]interface{}{
"type": "get_webhook_ok",
"enabled": d != nil,
"url": url,
"delivered": delivered,
"failed": failed,
"dropped": dropped,
"dlq_size": dlqLen,
"type": "get_webhook_ok",
"enabled": d != nil,
"url": url,
"delivered": delivered,
"failed": failed,
"dropped": dropped,
"dlq_size": dlqLen,
"dlq_dropped": dlqDropped,
}
}

Expand Down
4 changes: 4 additions & 0 deletions webhook/zz_more_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,10 @@ func TestDispatcher_AddToDLQ_DropsOldestWhenFull(t *testing.T) {
if got[0].EventID != 3 || got[1].EventID != 4 {
t.Errorf("DLQ contents = %v, want oldest dropped", got)
}
// Verify the dlqDropped counter tracks evictions (5 pushes into cap 2 = 3 drops).
if n := d.dlqDropped.Load(); n != 3 {
t.Errorf("dlqDropped = %d, want 3", n)
}
}

func TestDispatcher_EmitAfterCloseIsNoop(t *testing.T) {
Expand Down
Loading