Skip to content

chore: drop Node 20.x from CI matrix, add Node 24.x #40

Description

@pinecone-groundskeeper

Problem

.github/workflows/ci.yml's build-and-test matrix tested [20.x, 22.x]. Node.js 20 ("Iron") reached end-of-life on 2026-03-24 and no longer receives security or bug fixes, so CI was validating the project against an unsupported runtime.

Solution

Swap the matrix to the two currently-supported LTS lines: [22.x, 24.x]. The audit job's pinned node-version: 22.x is left as-is, matching the issue's acceptance criteria (explicitly a reviewer's call, not required).

Verification

Ran the full CI step sequence locally against Node 24.18.0 (in the new matrix range):

  • npm run lint — clean
  • npm run format:check — clean
  • npm run typecheck — clean
  • npm test — 5 files / 23 tests passed

(npm ci needed --ignore-scripts in this sandbox because onnxruntime-node's postinstall reaches api.nuget.org, which isn't reachable here; none of the exercised test files touch embeddings/onnxruntime, so this doesn't affect the verification above.)

Follow-ups

None — scope is intentionally limited to the Node version matrix per the issue.

Closes #32

Generated by GitHub Maintenance Fixer · sonnet50 · 49.4 AIC · ⌖ 9.22 AIC · ⊞ 8.1K ·


Note

This was originally intended as a pull request, but the git push operation failed.

Original error: The process '/usr/bin/git' failed with exit code 128

Workflow Run: View run details and download bundle artifact

The bundle file is available in the agent artifact in the workflow run linked above.

To create a pull request with the changes:

# Download the artifact from the workflow run
gh run download 30638646256 -n agent -D /tmp/agent-30638646256

# Fetch the bundle into a temporary ref, then update the local branch
git fetch /tmp/agent-30638646256/aw-pinecone-io-recommender-example-typescript-agent-maintenance-issue-32.bundle refs/heads/agent/maintenance/issue-32:refs/bundles/create-pr-agent-maintenance-issue-32-8ca7bf326c23b78a-2f1faf73
git update-ref refs/heads/agent/maintenance/issue-32-8ca7bf326c23b78a refs/bundles/create-pr-agent-maintenance-issue-32-8ca7bf326c23b78a-2f1faf73
git checkout agent/maintenance/issue-32-8ca7bf326c23b78a
# Ensure the working tree matches the updated branch
git reset --hard
# Remove the temporary bundle ref
git update-ref -d refs/bundles/create-pr-agent-maintenance-issue-32-8ca7bf326c23b78a-2f1faf73

# Push the branch to origin
git push origin agent/maintenance/issue-32-8ca7bf326c23b78a

# Create the pull request
gh pr create --title 'chore: drop Node 20.x from CI matrix, add Node 24.x' --base main --head agent/maintenance/issue-32-8ca7bf326c23b78a --repo pinecone-io/recommender-example-typescript

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent:maintenanceOpened/maintained by the maintenance agent; it recognizes its own work by this labelagentic-workflows

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions