Skip to content

doc: optimize English text for better translation in vector search overview#22923

Open
yahonda wants to merge 2 commits into
pingcap:release-8.5from
yahonda:fix-vector-search-storage-text-en
Open

doc: optimize English text for better translation in vector search overview#22923
yahonda wants to merge 2 commits into
pingcap:release-8.5from
yahonda:fix-vector-search-storage-text-en

Conversation

@yahonda
Copy link
Copy Markdown
Member

@yahonda yahonda commented May 25, 2026

This PR optimizes the English text in ai/concepts/vector-search-overview.md to be more natural and to ensure better automatic translation into Japanese. Specifically, it changes 'You can choose any of the following ways for storage:' to 'You can store your data in either of the following ways:', which leads to a more natural Japanese translation.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 25, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csuzhangxc for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 25, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vector search overview documentation to clarify data storage options. The reviewer suggested a further refinement to improve conciseness by removing unnecessary phrasing in the description of vector embeddings, aligning with the style guide's recommendation to avoid wordiness.

Comment thread ai/concepts/vector-search-overview.md Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@yahonda
Copy link
Copy Markdown
Member Author

yahonda commented May 25, 2026

The failure in the check-keywords job appears to be unrelated to the changes in this PR, as this PR only modifies ai/concepts/vector-search-overview.md and does not touch keywords.md or any related keyword definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant