Skip to content

Conversation

@tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #65106

Problem Summary:

What changed and how does it work?

tikv has supported _tidb_commt_ts tikv/tikv#19166
now this commit handle the same thing in unistore

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 18, 2025
@tiprow
Copy link

tiprow bot commented Dec 18, 2025

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 72.41379% with 8 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature/active-active@e352f59). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             feature/active-active     #65107   +/-   ##
==========================================================
  Coverage                         ?   73.3462%           
==========================================================
  Files                            ?       1860           
  Lines                            ?     508164           
  Branches                         ?          0           
==========================================================
  Hits                             ?     372719           
  Misses                           ?     113236           
  Partials                         ?      22209           
Flag Coverage Δ
integration 41.9179% <34.4827%> (?)
unit 72.2547% <72.4137%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 46.3377% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 18, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-18 06:20:45.827509667 +0000 UTC m=+1713190.641287269: ☑️ agreed by lcwangchao.

@tiancaiamao tiancaiamao changed the title unistore: support return _tidb_commit_ts for coprocessor request unistore: support return _tidb_commit_ts for coprocessor request | tidb-test=feature/active-active tikv=feature/active-active Dec 19, 2025
@tiancaiamao
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Dec 19, 2025

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants