-
Notifications
You must be signed in to change notification settings - Fork 6.1k
planner: optimize the schema check phase in the plan cache path #65118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
planner: optimize the schema check phase in the plan cache path #65118
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Reminiscent. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
pkg/planner/core/plan_cache.go
Outdated
| for i := range stmt.tbls { | ||
| sctx.GetSessionVars().StmtCtx.RelatedTableIDs[stmt.tbls[i].Meta().ID] = struct{}{} | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether this is required or not. PTAL @wjhuang2016
|
@Reminiscent: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the For example:
📖 For more info, you can check the "Contribute Code" section in the development guide. |
|
wait #65072 merged and add more benchmark test cases |
What problem does this PR solve?
Issue Number: ref #65117
Problem Summary:
optimize the schema check phase in the plan cache path
What changed and how does it work?
The cache key hashing logic is also optimized to reduce overhead in the hot path.
Check List
Tests
use the existing tests. Benchmark TBD.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.