-
Notifications
You must be signed in to change notification settings - Fork 6.1k
planner: fix no access path when TiKV read is disabled under RC isolation #65127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
82378ce to
492f8d7
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #65127 +/- ##
================================================
- Coverage 70.7556% 68.5957% -2.1599%
================================================
Files 1895 1873 -22
Lines 517902 510371 -7531
================================================
- Hits 366445 350093 -16352
- Misses 126934 137898 +10964
+ Partials 24523 22380 -2143
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…tion Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
d6a0157 to
9b3be4d
Compare
d9e67c6 to
095b0ec
Compare
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: you06 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
@hawkingrei: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@hawkingrei: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #65059
Problem Summary:
What changed and how does it work?
Because we use RC isolation, so
isForUpdateReadis true.tidb/pkg/planner/core/planbuilder.go
Lines 467 to 469 in 6540abd
Here will not remove the tikv path.
tidb/pkg/planner/core/logical_plan_builder.go
Lines 4491 to 4501 in 6540abd
findBestTask4LogicalDataSourcewill remove the tiflash path whenisForUpdateReadis truetidb/pkg/planner/core/find_best_task.go
Lines 1644 to 1667 in 6540abd
If this expression is not of the type "select for update" and there are no tikv replicas, even if it is set to RC, it will not cut off tiflash. However, if it is of the type "select for update," then tiflash will be cut off and it will be forced to use tikv.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.