-
Notifications
You must be signed in to change notification settings - Fork 6.1k
sessiontxn/staleread: don't overwrite StaleTSOProvider for single statement (#65110) #65128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
sessiontxn/staleread: don't overwrite StaleTSOProvider for single statement (#65110) #65128
Conversation
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #65128 +/- ##
================================================
Coverage ? 72.6323%
================================================
Files ? 1676
Lines ? 468779
Branches ? 0
================================================
Hits ? 340485
Misses ? 105632
Partials ? 22662
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MyonKeminta, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
|
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #65110
What problem does this PR solve?
Issue Number: close #65090
Problem Summary:
What changed and how does it work?
CalculateAsOfTsExprmay be called multi times when there are multi select-as-of-timestamp statements in one SQL, multi TSO providers can break the consistent requirement.Check List
Tests
I reran the tests described in the issue and the unexpected error never appears with this PR.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.