-
Notifications
You must be signed in to change notification settings - Fork 6.1k
planner: suppress column number in plan_tree explain #65148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @terry1purcell. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request suppresses column numbers in plan_tree explain output format, changing references like Column#6 to simply Column throughout the execution plans. This cosmetic change aims to simplify the explain output and make it more readable by removing internal column identifiers that are not typically meaningful to end users.
Key changes:
- Removed numeric suffixes from column references in plan tree output (e.g.,
Column#6->Column#7becomesColumn->Column) - Updated all test result files to reflect this change in explain format output
- No actual code functionality changes - only presentation of explain plans
Reviewed changes
Copilot reviewed 77 out of 77 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integrationtest/r/window_function.result | Updated window function explain outputs to use Column instead of numbered columns |
| tests/integrationtest/r/util/ranger.result | Updated explain outputs for index range scan queries |
| tests/integrationtest/r/tpch.result | Updated TPC-H benchmark query explain outputs |
| tests/integrationtest/r/topn_pushdown.result | Updated TopN pushdown explain outputs |
| tests/integrationtest/r/table/partition.result | Updated partition-related explain outputs |
| tests/integrationtest/r/subquery.result | Updated subquery explain outputs |
| tests/integrationtest/r/session/clustered_index.result | Updated clustered index explain outputs |
| tests/integrationtest/r/select.result | Updated various select query explain outputs |
| tests/integrationtest/r/planner/core/*.result | Updated numerous planner test explain outputs across multiple subdirectories |
| tests/integrationtest/r/null_rejected.result | Updated null rejection explain outputs |
| tests/integrationtest/r/infoschema/infoschema.result | Updated information schema explain outputs |
| tests/integrationtest/r/expression/misc.result | Updated expression-related explain outputs |
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit 36e3645 to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## master #65148 +/- ##
================================================
- Coverage 70.7452% 68.2530% -2.4922%
================================================
Files 1895 1872 -23
Lines 517984 510232 -7752
================================================
- Hits 366449 348249 -18200
- Misses 127012 139565 +12553
+ Partials 24523 22418 -2105
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 78 out of 89 changed files in this pull request and generated no new comments.
|
/ok-to-test |
|
@terry1purcell: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@terry1purcell: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #63118
Problem Summary:
What changed and how does it work?
Both EXPLAIN FORMAT=PLAN_TREE & FORMAT=BRIEF will remove the "physical operator numbers" from the explain output - to reduce those numbers causing irrelevant changes to optimizer tests. But that does NOT apply to the "physical operator number" assigned to each column in the plan.
This PR removes the "Column#num" suffix from EXPLAIN FORMAT=PLAN_TREE.
This does not extend to FORMAT=BRIEF simply because there are already 90+ file changes in this PR. FORMAT=BRIEF can be targeted in a separate PR.
Claude code's review is here:
75 Integration Test Result Files (.result files):
All changes in these files are exclusively column suffix removals. Every change follows this
pattern:
Examples from the diff:
Non-Test File Changes (2 files):
number suffixes in plan_tree format
Verification:
✅ CONFIRMED: The only changes to test files are column suffix removals (e.g., Column#14 →
Column)
✅ CONFIRMED: No other modifications to test content, logic, or structure
✅ CONFIRMED: All 76 test files follow the exact same pattern
The changes are clean and consistent across all test files - purely cosmetic removal of column
number suffixes with no functional changes to the tests themselves.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.