use cpu_features to improve compatibility

[SchrodingerZhu]

Signed-off-by: Schrodinger ZHU Yifan i@zhuyi.fan

What problem does this PR solve?

ld.lld: error: undefined symbol: __cpu_features2
>>> referenced by crc64.cpp:15 (/DATA/disk1/jaysonhuang/tics/libs/libcommon/src/crc64.cpp:15)
>>>               crc64.cpp.o:(crc64::Digest::Digest(crc64::Mode)) in archive libs/libcommon/libcommond.a
>>> referenced by crc64.cpp:25 (/DATA/disk1/jaysonhuang/tics/libs/libcommon/src/crc64.cpp:25)
>>>               crc64.cpp.o:(crc64::Digest::Digest(crc64::Mode)) in archive libs/libcommon/libcommond.a
clang-13: error: linker command failed with exit code 1 (use -v to see invocation)

address issue of gcc_s linkage when __builtin_cpu_supports are used.

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[SchrodingerZhu]

/run-all-tests

[SchrodingerZhu]

/run-all-tests

[SchrodingerZhu]

/run-all-tests

[sre-bot]

Coverage for changed files

Filename                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
dbms/src/Common/TargetSpecific.h                  166               129    22.29%          33                22    33.33%         101                57    43.56%          68                51    25.00%
libs/libcommon/include/common/mem_utils.h         127                66    48.03%           7                 3    57.14%         130                49    62.31%         116                58    50.00%
libs/libcommon/src/crc64.cpp                       33                 7    78.79%           4                 2    50.00%          51                19    62.75%          26                 9    65.38%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                             326               202    38.04%          44                27    38.64%         282               125    55.67%         210               118    43.81%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16384      9726             40.64%    179889  98644        45.16%

full coverage report (for internal network access only)

[SchrodingerZhu]

/merge

[ti-chi-bot]

@SchrodingerZhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Details

Commit hash: 47ebeb8

[sre-bot]

Coverage for changed files

Filename                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
dbms/src/Common/TargetSpecific.h                  166               129    22.29%          33                22    33.33%         101                57    43.56%          68                51    25.00%
libs/libcommon/include/common/mem_utils.h         127                66    48.03%           7                 3    57.14%         130                49    62.31%         116                58    50.00%
libs/libcommon/src/crc64.cpp                       33                 7    78.79%           4                 2    50.00%          51                19    62.75%          26                 9    65.38%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                             326               202    38.04%          44                27    38.64%         282               125    55.67%         210               118    43.81%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16384      9725             40.64%    179889  98638        45.17%

full coverage report (for internal network access only)

[jiaqizho]

Undefined symbols for architecture arm64:
  "_GetAarch64FeaturesEnumName", referenced from:
      _main in list_cpu_features.c.o
  "_GetAarch64FeaturesEnumValue", referenced from:
      _main in list_cpu_features.c.o
  "_GetAarch64Info", referenced from:
      _main in list_cpu_features.c.o

will get this error in the m1 build.

And fix patch in origin repo: Fix the build for M1 MacBooks #211