replay: include the timestamp in the traffic file names so that the files can be filtered by time#1070
Merged
Merged
Conversation
Collaborator
Author
|
/retest |
1 similar comment
Collaborator
Author
|
/retest |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1070 +/- ##
=======================================
Coverage ? 67.47%
=======================================
Files ? 140
Lines ? 14455
Branches ? 0
=======================================
Hits ? 9753
Misses ? 4031
Partials ? 671
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #1069
Problem Summary:
We usually specify a start timestamp for replay. Currently, the traffic file names are in the format
traffic-1.log. It's hard to locate the right file by a start timestamp.What is changed and how it works:
Include the timestamp in the traffic file names, such as
traffic-2025-09-10T17-01-56.073.log.Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.