Skip to content

replay: include the timestamp in the traffic file names so that the files can be filtered by time#1070

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:mainfrom
djshow832:log_files
Jan 29, 2026
Merged

replay: include the timestamp in the traffic file names so that the files can be filtered by time#1070
ti-chi-bot[bot] merged 1 commit into
pingcap:mainfrom
djshow832:log_files

Conversation

@djshow832
Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #1069

Problem Summary:
We usually specify a start timestamp for replay. Currently, the traffic file names are in the format traffic-1.log. It's hard to locate the right file by a start timestamp.

What is changed and how it works:
Include the timestamp in the traffic file names, such as traffic-2025-09-10T17-01-56.073.log.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot requested review from bb7133 and xhebox January 29, 2026 08:10
@ti-chi-bot ti-chi-bot Bot added the size/XL label Jan 29, 2026
@djshow832
Copy link
Copy Markdown
Collaborator Author

/retest

1 similar comment
@djshow832
Copy link
Copy Markdown
Collaborator Author

/retest

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 58.82353% with 21 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@f554cb5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/sqlreplay/store/rotate.go 58.82% 12 Missing and 9 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1070   +/-   ##
=======================================
  Coverage        ?   67.47%           
=======================================
  Files           ?      140           
  Lines           ?    14455           
  Branches        ?        0           
=======================================
  Hits            ?     9753           
  Misses          ?     4031           
  Partials        ?      671           
Flag Coverage Δ
unit 67.47% <58.82%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the lgtm label Jan 29, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 29, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-29 11:29:22.615701914 +0000 UTC m=+1270990.229658770: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot Bot added the approved label Jan 29, 2026
@ti-chi-bot ti-chi-bot Bot merged commit 1346b0a into pingcap:main Jan 29, 2026
6 checks passed
@djshow832 djshow832 deleted the log_files branch March 27, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the captured log file name format to be the same as audit logs

3 participants