Skip to content

cmd, replay: filter out the commands before command start time#878

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:mainfrom
YangKeao:impl-874
Sep 14, 2025
Merged

cmd, replay: filter out the commands before command start time#878
ti-chi-bot[bot] merged 1 commit into
pingcap:mainfrom
YangKeao:impl-874

Conversation

@YangKeao
Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: close #874

Problem Summary:

What is changed and how it works:

  1. Add a new field cmdstarttime in HTTP API.
  2. Add a new flag command-start-time in replayer and tiproxyctl cli.
  3. Modify the decoder to support filter out commands according to the config.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot Bot requested review from djshow832 and xhebox September 14, 2025 09:30
@ti-chi-bot ti-chi-bot Bot added the size/L label Sep 14, 2025
@pingcap-cla-assistant
Copy link
Copy Markdown

pingcap-cla-assistant Bot commented Sep 14, 2025

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 14, 2025

Codecov Report

❌ Patch coverage is 52.72727% with 26 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@76929fb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cmd/replayer/main.go 0.00% 9 Missing ⚠️
pkg/server/api/traffic.go 10.00% 8 Missing and 1 partial ⚠️
lib/cli/traffic.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #878   +/-   ##
=======================================
  Coverage        ?   67.35%           
=======================================
  Files           ?      133           
  Lines           ?    12858           
  Branches        ?        0           
=======================================
  Hits            ?     8661           
  Misses          ?     3598           
  Partials        ?      599           
Flag Coverage Δ
unit 67.35% <52.72%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Sep 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the lgtm label Sep 14, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Sep 14, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-14 10:38:40.320526645 +0000 UTC m=+789786.880408141: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot Bot added the approved label Sep 14, 2025
@ti-chi-bot ti-chi-bot Bot merged commit 5b1d0c3 into pingcap:main Sep 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support replaying with a specified start time

3 participants