replayer: support to load directories dynamically#973
Merged
Conversation
a444e39 to
353431f
Compare
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
8b6f1fe to
c7822cb
Compare
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
c7822cb to
c82ce83
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
=======================================
Coverage ? 67.46%
=======================================
Files ? 137
Lines ? 13885
Branches ? 0
=======================================
Hits ? 9367
Misses ? 3850
Partials ? 668
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djshow832
approved these changes
Nov 7, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djshow832 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #968
Problem Summary:
What is changed and how it works:
inputhas a little change.DirWatcheris used to walk the folder and create decoder dynamically.Limitation: This PR only supports to have a single input for
dynamic-input. It's indeed not difficult to support but we can make it simpler (to develop and to test) with this limitation. I think it can still cover the current scenario.You can run the S3 tests locally with minio:
Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.