Skip to content

Tiny fix for the problem that the Drainer monitoring configuration of Prometheus is lost due to spelling.#1012

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
SE-Bin:master
Dec 26, 2020
Merged

Tiny fix for the problem that the Drainer monitoring configuration of Prometheus is lost due to spelling.#1012
ti-chi-bot merged 3 commits intopingcap:masterfrom
SE-Bin:master

Conversation

@SE-Bin
Copy link
Copy Markdown
Contributor

@SE-Bin SE-Bin commented Dec 24, 2020

Tiny fix for the problem that the Drainer monitoring configuration of Prometheus is lost due to spelling.

What problem does this PR solve?

Tiny fix for the problem that the Drainer monitoring configuration of Prometheus is lost due to spelling.

What is changed and how it works?

Fix the spelling of "Drainer"

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release notes:

NONE

Tiny fix for the Prometheus configuration loss caused by Drainer spelling problem
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 24, 2020

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested review from july2993 and lonng December 24, 2020 11:13
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 24, 2020
Copy link
Copy Markdown
Contributor

@9547 9547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lucklove
Copy link
Copy Markdown
Member

lucklove commented Dec 24, 2020

/lgtm

It doesn't work if you left a comment /lgtm in Files changed tab, should left the comment in Conversations tab @9547

@lucklove
Copy link
Copy Markdown
Member

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 24, 2020
@9547
Copy link
Copy Markdown
Contributor

9547 commented Dec 24, 2020

/lgtm

@lucklove
Copy link
Copy Markdown
Member

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 24, 2020
@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 67aca2e

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 24, 2020

Codecov Report

Merging #1012 (0fe6e38) into master (aeacaf9) will increase coverage by 0.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1012      +/-   ##
==========================================
+ Coverage   55.16%   55.70%   +0.53%     
==========================================
  Files         279      279              
  Lines       19745    19745              
==========================================
+ Hits        10893    10998     +105     
+ Misses       7151     7038     -113     
- Partials     1701     1709       +8     
Flag Coverage Δ
cluster 43.64% <100.00%> (+0.67%) ⬆️
dm 23.96% <0.00%> (ø)
integrate 49.97% <100.00%> (+0.53%) ⬆️
playground 20.32% <ø> (ø)
tiup 16.47% <0.00%> (ø)
unittest 23.01% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/prometheus.go 74.17% <100.00%> (+2.64%) ⬆️
pkg/cluster/operation/scale_in.go 58.27% <0.00%> (+0.66%) ⬆️
pkg/cluster/spec/spec.go 88.57% <0.00%> (+0.71%) ⬆️
pkg/cluster/operation/destroy.go 56.61% <0.00%> (+1.01%) ⬆️
pkg/cluster/template/config/prometheus.go 63.93% <0.00%> (+3.27%) ⬆️
pkg/cluster/api/pdapi.go 61.30% <0.00%> (+4.64%) ⬆️
pkg/cluster/spec/tidb.go 68.04% <0.00%> (+5.15%) ⬆️
pkg/utils/http_client.go 72.97% <0.00%> (+5.40%) ⬆️
pkg/cluster/task/update_meta.go 80.00% <0.00%> (+6.15%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeacaf9...0fe6e38. Read the comment docs.

@ti-chi-bot
Copy link
Copy Markdown
Member

@SE-Bin: Your PR has out-of-dated and I have automatically updated it for you.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@AstroProfundis AstroProfundis added the status/need-info More information or actions need to be fufilled before we can process. label Dec 25, 2020
@AstroProfundis
Copy link
Copy Markdown
Contributor

@SE-Bin please sign the CLA so that we can merge the PR.

@ti-chi-bot ti-chi-bot merged commit 24289a3 into pingcap:master Dec 26, 2020
@lucklove lucklove added this to the v1.3.1 milestone Dec 31, 2020
lucklove pushed a commit that referenced this pull request Dec 31, 2020
Tiny fix for the Prometheus configuration loss caused by Drainer spelling problem

Co-authored-by: Ti Prow Robot <71242396+ti-community-prow-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first-time-contributor size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/need-info More information or actions need to be fufilled before we can process.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants