fix: workaround for nightly versions in checkConfig()#1281
Merged
lucklove merged 2 commits intopingcap:masterfrom Apr 7, 2021
Merged
fix: workaround for nightly versions in checkConfig()#1281lucklove merged 2 commits intopingcap:masterfrom
lucklove merged 2 commits intopingcap:masterfrom
Conversation
Member
|
/lgtm |
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by writing |
Member
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: a7492ef |
AstroProfundis
added a commit
that referenced
this pull request
Apr 7, 2021
Co-authored-by: SIGSEGV <gnu.crazier@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
If a cluster is deployed with the real version of nightly of that day, e.g.:
v5.0.0-nightly-20210405instead ofnightly, and when there is a new nightly version overwrites that value (and as we don't keep old nightly versions, thev5.0.0-nightly-20210405then no longer available in the repo), areloadoperation will fail withunknown versionerror.If the cluster was deployed with
nightlyas version, all seems working correctly.What is changed and how it works?
Check if the cluster version is a nightly version, and use
nightlyas version to query binary paths in repo for the component.This may, in theory, encounter issues when the deployed nightly version was so far behind the real latest nightly version, the the entry point path of component has changed since it was deployed and last upgraded.
Note that this should be considered as a workaround only, and we may need to refactor the
checkConfig()for better nightly version handling.Check List
Tests
Side effects
Related changes
Release notes: