Skip to content

server: fix not delete tmp file when upload package #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ti-chi-bot merged 3 commits into from
Sep 1, 2022
Merged

server: fix not delete tmp file when upload package #2021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd41401
server: fix not delete tmp file when upload package
nexustar Aug 15, 2022
7e3e5bb
ignore linter errcheck
nexustar Aug 15, 2022
a8ffdda
Merge branch 'master' into remove_multipart
AstroProfundis Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions server/handler/tarball.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,13 @@ func (h *tarballUploader) upload(r *http.Request) (*simpleResponse, statusError)
sid := mux.Vars(r)["sid"]
logprinter.Infof("Uploading tarball, sid: %s", sid)

if err := r.ParseMultipartForm(MaxMemory); err != nil {
// TODO: log error here
return nil, ErrorInvalidTarball
}

file, handler, err := r.FormFile("file")
if err != nil {
// TODO: log error here
return nil, ErrorInvalidTarball
}
defer file.Close()
defer r.MultipartForm.RemoveAll()

if err := h.sm.Write(sid, handler.Filename, file); err != nil {
logprinter.Errorf("Error to write tarball: %s", err.Error())
Expand Down
3 changes: 3 additions & 0 deletions tools/check/golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ linters-settings:
govet:
enable:
- nilness
errcheck:
exclude-functions:
- (*mime/multipart.Form).RemoveAll

linters:
disable-all: true
Expand Down