Support tikv label check#800
Merged
lucklove merged 20 commits intopingcap:masterfrom Sep 27, 2020
Merged
Conversation
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #800 +/- ##
==========================================
+ Coverage 48.65% 52.73% +4.07%
==========================================
Files 262 262
Lines 18850 18958 +108
==========================================
+ Hits 9172 9998 +826
+ Misses 8221 7403 -818
- Partials 1457 1557 +100
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
lonng
reviewed
Sep 22, 2020
lonng
reviewed
Sep 22, 2020
lonng
reviewed
Sep 22, 2020
lonng
reviewed
Sep 22, 2020
lonng
reviewed
Sep 22, 2020
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
lonng
reviewed
Sep 23, 2020
lonng
reviewed
Sep 23, 2020
lonng
reviewed
Sep 23, 2020
lonng
reviewed
Sep 23, 2020
Co-authored-by: Lonng <heng@lonng.org>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Contributor
|
/merge |
Contributor
|
Your auto merge job has been accepted, waiting for:
|
Contributor
|
/run-all-tests |
Contributor
|
@lucklove merge failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Check if tikv's label is set correctly: fix #787
What is changed and how it works?
Check List
Tests
Deploy
If both TiKV labels and PD labels not set:
If TiVK labels are set but PD's not:
Display
If both TiKV labels and PD labels not set:
If TiVK labels are set but PD's not:
In this case, TiKV will refuse to start
ScaleOut
The result is the same with deploy
Side effects
Related changes
Release notes: