Fix tiflash not start with newest nightly PD#902
Merged
AstroProfundis merged 3 commits intopingcap:masterfrom Nov 16, 2020
Merged
Fix tiflash not start with newest nightly PD#902AstroProfundis merged 3 commits intopingcap:masterfrom
AstroProfundis merged 3 commits intopingcap:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #902 +/- ##
==========================================
+ Coverage 53.24% 53.25% +0.01%
==========================================
Files 259 259
Lines 18785 18786 +1
==========================================
+ Hits 10002 10005 +3
+ Misses 7253 7251 -2
Partials 1530 1530
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
july2993
approved these changes
Nov 13, 2020
lucklove
added a commit
that referenced
this pull request
Nov 19, 2020
lucklove
added a commit
to lucklove/tiup
that referenced
this pull request
Apr 5, 2021
This reverts commit 402079d. We should reverts pingcap#902 because it introduced an issue: pingcap#1279 BTW, PD itself fixes pingcap#888 in tikv/pd#3163 So we don't need pingcap#902 anymore with recently released PD. However, after revert pingcap#902, *** old PDs (before #3163) may not work with tiup-playground ***
ti-chi-bot
pushed a commit
that referenced
this pull request
Apr 7, 2021
AstroProfundis
pushed a commit
that referenced
this pull request
Apr 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#888
What is changed and how it works?
Change "enable-placement-rules" to "false" before modify "max-replicas"
Check List
Tests
Related changes
Release notes: