Skip to content

cluster: ignore no tispark master error when listing clusters#920

Merged
lucklove merged 1 commit intopingcap:masterfrom
AstroProfundis:fix-909
Nov 19, 2020
Merged

cluster: ignore no tispark master error when listing clusters#920
lucklove merged 1 commit intopingcap:masterfrom
AstroProfundis:fix-909

Conversation

@AstroProfundis
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Fix #909

What is changed and how it works?

Ignore no tispark master error when listing clusters

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch

Release notes:

cluster: ignore no tispark master error when listing installed clusters

@AstroProfundis AstroProfundis added the type/bug-fix Categorizes PR as a bug-fix label Nov 19, 2020
@AstroProfundis AstroProfundis self-assigned this Nov 19, 2020
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #920 (fdda574) into master (bd9a03a) will increase coverage by 0.05%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #920      +/-   ##
==========================================
+ Coverage   53.09%   53.14%   +0.05%     
==========================================
  Files         260      260              
  Lines       18941    18946       +5     
==========================================
+ Hits        10056    10069      +13     
+ Misses       7340     7336       -4     
+ Partials     1545     1541       -4     
Flag Coverage Δ
cluster 45.19% <62.50%> (+0.08%) ⬆️
dm 25.03% <62.50%> (-0.05%) ⬇️
integrate 47.74% <62.50%> (+0.05%) ⬆️
playground 22.09% <ø> (ø)
tiup 10.67% <ø> (ø)
unittest 21.51% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager.go 67.63% <62.50%> (+0.26%) ⬆️
pkg/cluster/api/dmapi.go 58.26% <0.00%> (-1.74%) ⬇️
pkg/cluster/api/pdapi.go 61.30% <0.00%> (+1.23%) ⬆️
pkg/cluster/api/binlog.go 38.93% <0.00%> (+1.76%) ⬆️
pkg/utils/http_client.go 72.22% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd9a03a...fdda574. Read the comment docs.

Copy link
Copy Markdown
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 19, 2020
@lucklove lucklove merged commit afcaf6f into pingcap:master Nov 19, 2020
@lucklove lucklove added this to the v1.2.4 milestone Nov 19, 2020
@AstroProfundis AstroProfundis deleted the fix-909 branch November 19, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to list cluster if there is an error of topology validate

4 participants