Playground: fix missing config file for tiflash#969
Conversation
Codecov Report
@@ Coverage Diff @@
## master #969 +/- ##
==========================================
+ Coverage 55.48% 55.53% +0.04%
==========================================
Files 264 264
Lines 19856 19858 +2
==========================================
+ Hits 11017 11028 +11
+ Misses 7114 7103 -11
- Partials 1725 1727 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Please add a new test case in tests/tiup-playground/test_playground.sh, thank you. Maybe you can try to replace 0 with 1 and to see if the Github CI has enough memory to run TiFlash. |
Thanks for your reminder |
|
/merge |
|
@lucklove: adding 'status/can-merge' to this PR must have 1 LGTMs DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository. |
|
/merge |
|
@lucklove: adding 'status/can-merge' to this PR must have 1 LGTMs DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository. |
What problem does this PR solve?
When tiup playground starts tiflash, it outputs
It's because config file haven't been created, and this is because directory
/root/.tiup/data/SI4xAjv/tiflash-0/haven't been created in this case .What is changed and how it works?
create the directory to store config file for tiflash before creating config file
Check List
Tests
Related changes
Release notes: