Skip to content

Playground: fix missing config file for tiflash#969

Merged
lucklove merged 8 commits intopingcap:masterfrom
unbyte:fix-playground-tiflash
Dec 10, 2020
Merged

Playground: fix missing config file for tiflash#969
lucklove merged 8 commits intopingcap:masterfrom
unbyte:fix-playground-tiflash

Conversation

@unbyte
Copy link
Copy Markdown
Contributor

@unbyte unbyte commented Dec 3, 2020

What problem does this PR solve?

When tiup playground starts tiflash, it outputs

image

It's because config file haven't been created, and this is because directory /root/.tiup/data/SI4xAjv/tiflash-0/ haven't been created in this case .

What is changed and how it works?

create the directory to store config file for tiflash before creating config file

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested a review from lonng December 3, 2020 15:49
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 3, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 3, 2020

Codecov Report

Merging #969 (038d263) into master (ebc75de) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #969      +/-   ##
==========================================
+ Coverage   55.48%   55.53%   +0.04%     
==========================================
  Files         264      264              
  Lines       19856    19858       +2     
==========================================
+ Hits        11017    11028      +11     
+ Misses       7114     7103      -11     
- Partials     1725     1727       +2     
Flag Coverage Δ
cluster 43.42% <ø> (+0.07%) ⬆️
dm 24.03% <ø> (ø)
integrate 49.83% <0.00%> (+0.05%) ⬆️
playground 20.29% <0.00%> (-0.01%) ⬇️
tiup 16.45% <ø> (ø)
unittest 22.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/instance/tiflash.go 0.00% <0.00%> (ø)
pkg/utils/http_client.go 66.66% <0.00%> (-5.56%) ⬇️
pkg/cluster/api/pdapi.go 60.99% <0.00%> (-0.62%) ⬇️
pkg/cluster/spec/tikv.go 57.63% <0.00%> (+1.47%) ⬆️
pkg/cluster/spec/pd.go 71.16% <0.00%> (+2.45%) ⬆️
pkg/cluster/template/scripts/pd.go 71.87% <0.00%> (+3.12%) ⬆️
pkg/utils/retry.go 65.78% <0.00%> (+15.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc75de...038d263. Read the comment docs.

Copy link
Copy Markdown
Contributor

@9547 9547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@9547
Copy link
Copy Markdown
Contributor

9547 commented Dec 3, 2020

Please add a new test case in tests/tiup-playground/test_playground.sh, thank you. Maybe you can try to replace 0 with 1 and to see if the Github CI has enough memory to run TiFlash.

tiup-playground v4.0.4 --tiflash 0 > $outfile 2>&1 &

@unbyte
Copy link
Copy Markdown
Contributor Author

unbyte commented Dec 3, 2020

Please add a new test case in tests/tiup-playground/test_playground.sh, thank you. Maybe you can try to replace 0 with 1 and to see if the Github CI has enough memory to run TiFlash.

Thanks for your reminder

@lucklove
Copy link
Copy Markdown
Member

lucklove commented Dec 4, 2020

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@lucklove: adding 'status/can-merge' to this PR must have 1 LGTMs

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository.

@lucklove
Copy link
Copy Markdown
Member

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@lucklove: adding 'status/can-merge' to this PR must have 1 LGTMs

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository.

@lucklove lucklove merged commit 9e5f2bd into pingcap:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants