fix(cluster): quote surround wildcard by 9547 · Pull Request #982 · pingcap/tiup

9547 · 2020-12-10T16:08:17Z

What problem does this PR solve?

fix #974

What is changed and how it works?

Check List

Tests
Manual test:

before fix

after fix

success

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

codecov-io · 2020-12-10T16:10:54Z

Codecov Report

Merging #982 (3c98ed3) into master (d36a601) will decrease coverage by 2.61%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
- Coverage   54.37%   51.75%   -2.62%     
==========================================
  Files         279      279              
  Lines       19716    19709       -7     
==========================================
- Hits        10721    10201     -520     
- Misses       7314     7889     +575     
+ Partials     1681     1619      -62

Flag	Coverage Δ
cluster	`38.35% <18.18%> (-2.65%)`	⬇️
dm	`23.85% <63.63%> (-0.02%)`	⬇️
integrate	`46.07% <63.63%> (-2.51%)`	⬇️
playground	`20.28% <ø> (ø)`
tiup	`16.46% <0.00%> (+0.01%)`	⬆️
unittest	`23.09% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/cluster/spec/prometheus.go	`68.21% <45.45%> (+1.32%)`	⬆️
pkg/cluster/spec/grafana.go	`68.00% <81.81%> (+3.65%)`	⬆️
components/cluster/command/check.go	`6.27% <0.00%> (-73.27%)`	⬇️
pkg/cluster/task/limits.go	`0.00% <0.00%> (-68.75%)`	⬇️
pkg/cluster/task/sysctl.go	`0.00% <0.00%> (-66.67%)`	⬇️
components/cluster/command/audit.go	`27.27% <0.00%> (-54.55%)`	⬇️
pkg/cluster/operation/check.go	`0.00% <0.00%> (-52.54%)`	⬇️
pkg/cluster/manager/patch.go	`0.00% <0.00%> (-51.81%)`	⬇️
pkg/cluster/task/rmdir.go	`0.00% <0.00%> (-50.00%)`	⬇️
pkg/cluster/operation/operation.go	`34.78% <0.00%> (-43.48%)`	⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d36a601...3c98ed3. Read the comment docs.

This reverts commit a2a7a8e.

Co-authored-by: SIGSEGV <gnu.crazier@gmail.com>

9547 · 2020-12-14T15:16:41Z

@lucklove PTAL

lucklove · 2020-12-15T04:24:02Z

/lgtm

lucklove · 2020-12-15T04:30:26Z

/merge

ti-chi-bot · 2020-12-15T04:30:31Z

Can merge label has been added.

Details

Git tree hash: 3c98ed3

Introduced by pingcap#982 Close pingcap#1055

Introduced by #982 Close #1055 Co-authored-by: Ti Prow Robot <71242396+ti-community-prow-bot@users.noreply.github.com>

ti-chi-bot requested review from AstroProfundis and lonng December 10, 2020 16:08

ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 10, 2020

lucklove reviewed Dec 11, 2020

View reviewed changes

Comment thread .github/workflows/integrate-cluster-cmd.yaml Outdated

Comment thread pkg/cluster/spec/grafana.go Outdated

Comment thread pkg/cluster/spec/grafana.go Outdated

Comment thread pkg/cluster/spec/prometheus.go Outdated

Comment thread pkg/cluster/spec/prometheus.go Outdated

9547 added 5 commits December 11, 2020 23:30

fix(cluster): quote surround wildcard

026f72b

feat(github): test compatible with zsh or not

5f512e7

Revert "fix(cluster): quote surround wildcard"

4147520

This reverts commit a2a7a8e.

fix(cluster): ignore no_match error if wildcard not matched in zsh

8720ee4

feat(cluster): rm files with find -delete

67e2483

9547 force-pushed the fix/zsh-wildcard branch from 8be231f to 67e2483 Compare December 11, 2020 16:08

ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2020

9547 and others added 2 commits December 12, 2020 00:11

feat(github): don't test with zsh

3bc8511

Merge branch 'master' into fix/zsh-wildcard

698aeea

lucklove reviewed Dec 14, 2020

View reviewed changes

Comment thread pkg/cluster/spec/prometheus.go Outdated

Comment thread pkg/cluster/spec/prometheus.go Outdated

Comment thread pkg/cluster/spec/grafana.go Outdated

9547 and others added 2 commits December 14, 2020 22:54

Update pkg/cluster/spec/prometheus.go

e69b32e

Co-authored-by: SIGSEGV <gnu.crazier@gmail.com>

typo(cluster): rm duplicated targetDir

4daea51

Merge branch 'master' into fix/zsh-wildcard

3c98ed3

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 15, 2020

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 15, 2020

ti-chi-bot merged commit efcaf79 into pingcap:master Dec 15, 2020

AstroProfundis mentioned this pull request Dec 16, 2020

tiup cluster deploy will fail #991

Closed

King-Dylan mentioned this pull request Dec 18, 2020

Bump v1.3.0 #998

Merged

lucklove added a commit to lucklove/tiup that referenced this pull request Jan 11, 2021

Fix the issue that dm grafana doen't has home.json

f09882b

Introduced by pingcap#982 Close pingcap#1055

lucklove added a commit to lucklove/tiup that referenced this pull request Jan 11, 2021

Fix the issue that dm grafana doen't has home.json

714f33c

Introduced by pingcap#982 Close pingcap#1055

lucklove mentioned this pull request Jan 11, 2021

Fix the issue that dm grafana doen't has home.json #1056

Merged

ti-chi-bot added a commit that referenced this pull request Jan 12, 2021

Fix the issue that dm grafana doen't has home.json (#1056)

a246cfa

Introduced by #982 Close #1055 Co-authored-by: Ti Prow Robot <71242396+ti-community-prow-bot@users.noreply.github.com>

lucklove added a commit that referenced this pull request Jan 28, 2021

Fix the issue that dm grafana doen't has home.json (#1056)

9c12344

Introduced by #982 Close #1055 Co-authored-by: Ti Prow Robot <71242396+ti-community-prow-bot@users.noreply.github.com>

9547 deleted the fix/zsh-wildcard branch April 6, 2021 23:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cluster): quote surround wildcard#982

fix(cluster): quote surround wildcard#982
ti-chi-bot merged 10 commits intopingcap:masterfrom
jsvisa:fix/zsh-wildcard

9547 commented Dec 10, 2020 •

edited

Loading

Uh oh!

codecov-io commented Dec 10, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

9547 commented Dec 14, 2020

Uh oh!

lucklove commented Dec 15, 2020

Uh oh!

lucklove commented Dec 15, 2020

Uh oh!

ti-chi-bot commented Dec 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

9547 commented Dec 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Uh oh!

codecov-io commented Dec 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

9547 commented Dec 14, 2020

Uh oh!

lucklove commented Dec 15, 2020

Uh oh!

lucklove commented Dec 15, 2020

Uh oh!

ti-chi-bot commented Dec 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

9547 commented Dec 10, 2020 •

edited

Loading

codecov-io commented Dec 10, 2020 •

edited

Loading