Command failure tolerance

[juliusmarminge]

Make terminal write and resize tolerant of exited processes to prevent errors when a terminal closes.

The terminal's write and resize methods were throwing errors when called on a process that had already exited (e.g., after an exit command), causing error messages to appear in the UI. This change makes these operations silently return or catch errors, allowing the terminal to close gracefully without user-facing errors.

---

  

Note

Make TerminalManagerRuntime.write and TerminalManagerRuntime.resize tolerate command failures in Manager.ts by returning early when the terminal is missing or exited

Update terminal runtime methods to return without throwing when the session is absent or exited and wrap process calls in try/catch; add tests asserting resolved promises on exited sessions in Manager.test.ts.

📍Where to Start

Start with the TerminalManagerRuntime.write and TerminalManagerRuntime.resize implementations in Manager.ts.

📊 Macroscope summarized 25ea66c. 1 file reviewed, 2 issues evaluated, 0 issues filtered, 1 comment posted

🗂️ Filtered Issues

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch cursor/command-failure-tolerance-a10d

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

🟢 Low Layers/Manager.ts:455

Consider moving session.cols and session.rows assignments inside the try block, after session.process.resize() succeeds. Currently, if resize() throws, the session state will reflect dimensions the PTY never adopted.

-    session.cols = input.cols;
-    session.rows = input.rows;
-    session.updatedAt = new Date().toISOString();
     try {
       session.process.resize(input.cols, input.rows);
+      session.cols = input.cols;
+      session.rows = input.rows;
+      session.updatedAt = new Date().toISOString();
     } catch {

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file apps/server/src/terminal/Layers/Manager.ts around lines 455-462:

Consider moving `session.cols` and `session.rows` assignments inside the `try` block, after `session.process.resize()` succeeds. Currently, if `resize()` throws, the session state will reflect dimensions the PTY never adopted.

Evidence trail:
apps/server/src/terminal/Layers/Manager.ts lines 450-464 at REVIEWED_COMMIT: The `resize` method shows `session.cols = input.cols` (line 456) and `session.rows = input.rows` (line 457) are assigned BEFORE the `try` block. The `session.process.resize(input.cols, input.rows)` call is inside the `try` block (line 460). The catch block comment confirms the known failure mode: "Process may have exited between the status check and the resize call."