Skip to content

fix(server): extend negative repository identity cache ttl #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Apr 16, 2026
Merged

fix(server): extend negative repository identity cache ttl #2083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions apps/server/src/project/Layers/RepositoryIdentityResolver.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ it.layer(NodeServices.layer)("RepositoryIdentityResolverLive", (it) => {
);

it.effect(
"refreshes cached null identities after the negative TTL when a remote is configured later",
"keeps null identities cached across repeated resolves until the negative TTL expires",
() =>
Effect.gen(function* () {
const fileSystem = yield* FileSystem.FileSystem;
Expand All @@ -128,8 +128,10 @@ it.layer(NodeServices.layer)("RepositoryIdentityResolverLive", (it) => {

yield* git(cwd, ["remote", "add", "origin", "git@github.com:T3Tools/t3code.git"]);

const cachedIdentity = yield* resolver.resolve(cwd);
expect(cachedIdentity).toBeNull();
for (const _attempt of [1, 2, 3]) {
const cachedIdentity = yield* resolver.resolve(cwd);
expect(cachedIdentity).toBeNull();
}

yield* TestClock.adjust(Duration.millis(120));

Expand Down
2 changes: 1 addition & 1 deletion apps/server/src/project/Layers/RepositoryIdentityResolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ function buildRepositoryIdentity(input: {

const DEFAULT_REPOSITORY_IDENTITY_CACHE_CAPACITY = 512;
const DEFAULT_POSITIVE_CACHE_TTL = Duration.minutes(1);
const DEFAULT_NEGATIVE_CACHE_TTL = Duration.seconds(10);
const DEFAULT_NEGATIVE_CACHE_TTL = Duration.minutes(1);

interface RepositoryIdentityResolverOptions {
readonly cacheCapacity?: number;
Expand Down
Loading