feat: adds floating terminal layout by adamt94 · Pull Request #2344 · pingdotgg/t3code

adamt94 · 2026-04-25T13:39:27Z

Summary

Adds an option to have the terminal in a floating window

add a client setting for docked vs floating terminal layout
render the existing terminal drawer in a floating window when selected

Settings page

floating terminal

Note

Medium Risk
Adds a new persisted client setting and expands per-thread terminal persisted state to include terminalWidth, which could impact settings/state decoding and UI behavior across sessions. Main changes are UI/layout-related, but touch shared contracts and state persistence paths.

Overview
Adds a new terminalLayout client setting (docked | floating) and wires it through ChatView/ChatHeader so the terminal can render either as the existing docked drawer or as a modal-like floating window.

When floating is selected, the terminal is shown in a backdrop overlay with outside-click/close-button dismissal and resizable width; terminal state persistence is extended to store terminalWidth, and ThreadTerminalDrawer adjusts its max height/border styling based on layout.

Updates the Settings panel to let users choose/reset terminal layout, and updates tests/initial browser terminal state to include the new fields/defaults.

^{Reviewed by Cursor Bugbot for commit 7954880. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add floating terminal layout option as an alternative to the docked drawer

Adds a TerminalLayout type ('docked' | 'floating') to client settings in settings.ts, defaulting to 'docked'.
When set to 'floating', the terminal renders as a centered modal dialog with a backdrop, close button, and left/right resize handles instead of the bottom drawer.
Terminal width is now tracked per-thread in terminalStateStore.ts, persisted after pointer drag ends, and clamped between 400px and 97% of viewport width.
Floating layout allows up to 92% viewport height vs. 75% for docked; the top border is removed in floating mode.
A new "Terminal layout" select control in SettingsPanels.tsx lets users switch layouts and reset to default.

📊 Macroscope summarized 7954880. 8 files reviewed, 3 issues evaluated, 0 issues filtered, 2 comments posted

🗂️ Filtered Issues

coderabbitai · 2026-04-25T13:39:35Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 03e4035a-3804-47c1-94e3-4fe80f44fb17

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

macroscopeapp · 2026-04-25T13:44:15Z

Approvability

Verdict: Needs human review

2 blocking correctness issues found. This PR introduces a new feature (floating terminal layout) with new user-facing behavior and UI components. Additionally, unresolved review comments identify substantive bugs: the restore defaults functionality doesn't reset the new terminal layout setting, and height clamping may not work correctly when switching between layouts.

^{You can customize Macroscope's approvability policy. Learn more.}

- add terminal layout setting and contract schema - render the thread terminal as a floating dialog when enabled - switch package scripts to run under Bun

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 7954880. Configure here.}

cursor · 2026-05-17T15:01:13Z

      settings.automaticGitFetchInterval,
      settings.enableAssistantStreaming,
      settings.sidebarThreadPreviewCount,
+      settings.terminalLayout,


Restore defaults omits terminalLayout from reset

Medium Severity

The changedSettingLabels memo correctly detects when terminalLayout differs from its default and includes "Terminal layout" in the list shown in the confirmation dialog. However, the restoreDefaults callback's updateSettings call does not include terminalLayout, so the setting is never actually reset. The user sees it promised as restored but it stays unchanged.

Additional Locations (1)

apps/web/src/components/settings/SettingsPanels.tsx#L413-L416

^{Reviewed by Cursor Bugbot for commit 7954880. Configure here.}

macroscopeapp · 2026-05-17T15:02:53Z

🟠 High

t3code/apps/web/src/components/settings/SettingsPanels.tsx

Line 467 in 7954880

updateSettings({

The diff adds terminalLayout detection to changedSettingLabels (lines 414-416), so users see "Terminal layout" in the reset confirmation dialog, but restoreDefaults omits terminalLayout from the updateSettings call. The setting appears resettable but silently persists when confirmed.

🤖 Copy this AI Prompt to have your agent fix this:

In file apps/web/src/components/settings/SettingsPanels.tsx around line 467: The diff adds `terminalLayout` detection to `changedSettingLabels` (lines 414-416), so users see "Terminal layout" in the reset confirmation dialog, but `restoreDefaults` omits `terminalLayout` from the `updateSettings` call. The setting appears resettable but silently persists when confirmed. Evidence trail: apps/web/src/components/settings/SettingsPanels.tsx lines 414-416 (terminalLayout in changedSettingLabels) and lines 467-480 (updateSettings call omitting terminalLayout) at REVIEWED_COMMIT.

macroscopeapp · 2026-05-17T15:02:53Z

    onHeightChangeRef.current(clampedHeight);
  }, []);

  useEffect(() => {


🟡 Medium components/ThreadTerminalDrawer.tsx:1034

When the layout prop changes from "floating" to "docked", the drawer height is not re-clamped to the new maximum. The effect at line 1034 only depends on [height, threadId], so it won't run when layout changes, leaving a height of 800px (valid for floating's 920px max) exceeding docked's 750px max.

🤖 Copy this AI Prompt to have your agent fix this:

In file apps/web/src/components/ThreadTerminalDrawer.tsx around line 1034: When the `layout` prop changes from `"floating"` to `"docked"`, the drawer height is not re-clamped to the new maximum. The effect at line 1034 only depends on `[height, threadId]`, so it won't run when `layout` changes, leaving a height of 800px (valid for floating's 920px max) exceeding docked's 750px max. Evidence trail: apps/web/src/components/ThreadTerminalDrawer.tsx lines 55-56 (ratio constants: 0.75 and 0.92), line 64-68 (clampDrawerHeight function), lines 884-887 (maxHeightRatio derived from layout, ref updated but no effect triggered), lines 1034-1039 (effect depends on [height, threadId] only), lines 1086-1107 (window resize handler only fires on window resize, not layout change). No other effect in the file depends on `layout`.

github-actions Bot added size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 25, 2026

adamt94 changed the title ~~Add floating terminal layout~~ Adds floating terminal layout Apr 25, 2026

adamt94 force-pushed the feat/floating-terminal branch from c78fad9 to df27669 Compare April 25, 2026 13:42

cursor Bot reviewed Apr 25, 2026

View reviewed changes

Comment thread apps/web/src/components/ChatView.tsx

adamt94 force-pushed the feat/floating-terminal branch from df27669 to 2343d3d Compare April 25, 2026 14:06

cursor Bot reviewed Apr 25, 2026

View reviewed changes

Comment thread apps/web/src/components/ChatView.tsx Outdated

adamt94 force-pushed the feat/floating-terminal branch from 2343d3d to 4796964 Compare April 25, 2026 14:22

adamt94 changed the title ~~Adds floating terminal layout~~ feat: adds floating terminal layout Apr 25, 2026

adamt94 added 2 commits May 17, 2026 15:49

Add floating terminal layout support

9793b4f

- add terminal layout setting and contract schema - render the thread terminal as a floating dialog when enabled - switch package scripts to run under Bun

makes terminal more adjustable

7954880

adamt94 force-pushed the feat/floating-terminal branch from f5b32fe to 7954880 Compare May 17, 2026 14:54

cursor Bot reviewed May 17, 2026

View reviewed changes

macroscopeapp Bot reviewed May 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: adds floating terminal layout#2344

feat: adds floating terminal layout#2344
adamt94 wants to merge 2 commits into
pingdotgg:mainfrom
adamt94:feat/floating-terminal

adamt94 commented Apr 25, 2026 •

edited by macroscopeapp Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 25, 2026 •

edited

Loading

Review skipped

Uh oh!

macroscopeapp Bot commented Apr 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot May 17, 2026

Uh oh!

macroscopeapp Bot May 17, 2026

Uh oh!

macroscopeapp Bot May 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

adamt94 commented Apr 25, 2026 • edited by macroscopeapp Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Settings page

floating terminal

Add floating terminal layout option as an alternative to the docked drawer

🗂️ Filtered Issues

Uh oh!

coderabbitai Bot commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

macroscopeapp Bot commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot May 17, 2026

Choose a reason for hiding this comment

Restore defaults omits terminalLayout from reset

Uh oh!

macroscopeapp Bot May 17, 2026

Choose a reason for hiding this comment

Uh oh!

macroscopeapp Bot May 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

adamt94 commented Apr 25, 2026 •

edited by macroscopeapp Bot

Loading

coderabbitai Bot commented Apr 25, 2026 •

edited

Loading

macroscopeapp Bot commented Apr 25, 2026 •

edited

Loading