-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add new GitHub users to VOUCHED.td #2425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,3 +30,6 @@ github:Yash-Singh1 | |
| github:eggfriedrice24 | ||
| github:Ymit24 | ||
| github:shivamhwp | ||
| github:jappyjan | ||
| github:justsomelegs | ||
| github:UtkarshUsername | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New entries violate alphabetical sorting requirementLow Severity The file comment on line 11 says "Keep entries sorted alphabetically," but the three new entries ( Reviewed by Cursor Bugbot for commit 2e58f06. Configure here. |
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undisclosed user added to security trust list
High Severity
The PR description explicitly states it adds
jappyjanandjustsomelegs, butgithub:UtkarshUsernameis also added to the trust list without being mentioned anywhere in the PR title or description. SinceVOUCHED.tdcontrols which external contributors are treated as trusted by the vouch workflow, an undisclosed addition to this file is a security concern — it could grant trusted CI/workflow status to an unvetted user.Reviewed by Cursor Bugbot for commit 2e58f06. Configure here.