Skip to content

[codex] fix Discord release version flag #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
May 1, 2026
+6 −6
Merged

[codex] fix Discord release version flag #2449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ jobs:
node scripts/notify-discord-release.ts prerelease \
--role-id "$DISCORD_MENTION_ROLE_ID" \
--release-name "${{ needs.preflight.outputs.release_name }}" \
--version "${{ needs.preflight.outputs.version }}" \
--release-version "${{ needs.preflight.outputs.version }}" \
--tag "${{ needs.preflight.outputs.tag }}" \
--release-url "https://github.com/${{ github.repository }}/releases/tag/${{ needs.preflight.outputs.tag }}"

Expand All @@ -642,6 +642,6 @@ jobs:
node scripts/notify-discord-release.ts latest \
--role-id "$DISCORD_MENTION_ROLE_ID" \
--release-name "${{ needs.preflight.outputs.release_name }}" \
--version "${{ needs.preflight.outputs.version }}" \
--release-version "${{ needs.preflight.outputs.version }}" \
--tag "${{ needs.preflight.outputs.tag }}" \
--release-url "https://github.com/${{ github.repository }}/releases/tag/${{ needs.preflight.outputs.tag }}"
8 changes: 4 additions & 4 deletions scripts/notify-discord-release.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ export const notifyDiscordReleaseCommand = Command.make(
Flag.withSchema(Schema.NonEmptyString),
Flag.withDescription("Human-readable release name."),
),
version: Flag.string("version").pipe(
releaseVersion: Flag.string("release-version").pipe(
Flag.withSchema(Schema.NonEmptyString),
Flag.withDescription("Release version."),
),
Expand All @@ -186,15 +186,15 @@ export const notifyDiscordReleaseCommand = Command.make(
Flag.withDescription("Public GitHub release URL."),
),
},
({ target, roleId, releaseName, version, tag, releaseUrl }) =>
({ target, roleId, releaseName, releaseVersion, tag, releaseUrl }) =>
Effect.gen(function* () {
yield* Effect.logInfo("discord release announcement starting").pipe(
Effect.annotateLogs({
target,
roleIdProvided: roleId.length > 0,
roleIdLength: roleId.length,
releaseName,
version,
version: releaseVersion,
tag,
releaseUrl,
}),
Expand All @@ -205,7 +205,7 @@ export const notifyDiscordReleaseCommand = Command.make(
target,
roleId,
releaseName,
version,
version: releaseVersion,
tag,
releaseUrl,
timestamp: new Date().toISOString(),
Expand Down
Loading