Support two-digit sidebar thread jumps#2623
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
vouch:unvouched
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ApprovabilityVerdict: Needs human review New user-facing feature adding two-digit keyboard navigation with an unresolved bug report about edge case handling where navigation intent can be silently lost. You can customize Macroscope's approvability policy. Learn more. |
svenbuild
force-pushed
the
sidebar-two-digit-thread-jumps
branch
from
90fcd63 to
667a308
Compare
svenbuild
force-pushed
the
sidebar-two-digit-thread-jumps
branch
from
667a308 to
70800d6
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70800d6771
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c2dbcee23
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c6ea631c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
svenbuild
force-pushed
the
sidebar-two-digit-thread-jumps
branch
from
5c6ea63 to
8c4df85
Compare
github-actions
Bot
added
size:L
svenbuild
force-pushed
the
sidebar-two-digit-thread-jumps
branch
from
8c4df85 to
c86187b
Compare
github-actions
Bot
added
size:M
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c86187bea1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
svenbuild
force-pushed
the
sidebar-two-digit-thread-jumps
branch
from
c86187b to
f0c795e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0c795e764
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
svenbuild
force-pushed
the
sidebar-two-digit-thread-jumps
branch
from
f0c795e to
877be96
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 877be96. Configure here.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63e56aef35
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
Ctrl+9with labels likeCtrl+10andCtrl+15.thread.jump.1throughthread.jump.9keybinding commands unchanged.Why
This keeps the existing shortcut model but makes it work for longer thread lists without adding new keybinding commands.
Interaction notes
Ctrl+1still jumps to thread 1 after the short timeout.Ctrl+1, then5within the timeout jumps to visible thread 15.Ctrl+1,5without releasingCtrl.Verification
bun run test src/components/Sidebar.logic.test.tsfromapps/webbun run typecheck --filter=@t3tools/webgit diff --checkNote
Support two-digit thread jump shortcuts in the sidebar
buildThreadJumpLabelMapin Sidebar.tsx to generate composite shortcut labels for threads 10–99 based on the first digit's command and the second digit.Macroscope summarized dc74d9e.
Note
Medium Risk
Changes global sidebar keydown handling to introduce a pending-digit state and 250ms timeout, which could impact existing single-digit jump responsiveness and shortcut interactions. Limited to client-side navigation/hint rendering with no security/data-path changes.
Overview
Adds two-digit sidebar thread jump shortcuts (10–99) by treating
thread.jump.1–thread.jump.9as the first digit and accepting a second numeric key within a 250ms window before navigating.Updates
buildThreadJumpLabelMapto synthesize and display hint labels for visible threads beyond 9 (e.g.Ctrl+10,Ctrl+15), and ensures pending jump state/timeouts are cleared on navigation, route changes, and unmount.Reviewed by Cursor Bugbot for commit dc74d9e. Bugbot is set up for automated code reviews on this repo. Configure here.