-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(ux): spamming cmd + , no longer stack opening settings #2757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ea54c3d
Replace settings route when reopening settings
jamesx0416 a954a23
Merge branch 'main' into t3code/01790fbd
jamesx0416 916a1b2
fix: check settings route boundary
jamesx0416 602550b
Merge upstream/main into t3code/01790fbd
jamesx0416 2f91bad
Merge upstream/main into t3code/01790fbd
jamesx0416 0f9f5dc
Make settings shortcut a no-op within settings
jamesx0416 7b9d376
Merge main into t3code/01790fbd
juliusmarminge e1d5fca
Merge branch 'main' into t3code/01790fbd
juliusmarminge 007264d
Merge branch 'main' into t3code/01790fbd
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.