Bscholar/pi rpc

[bscholar-tt]

What Changed

Why

UI Changes

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

---

Note

High Risk
Large new provider adapter and release-pipeline changes affect core agent execution and how CLI/desktop are shipped; remote install now depends on GitHub release assets.

Overview
Adds a first-class Pi Agent provider that runs the pi CLI in RPC mode and maps its JSONL events (turns, tools, streaming text, extension UI prompts) into T3’s provider runtime, plus settings/UI wiring and structured text-generation via Pi.

Fork-oriented release and distribution: CI/release runners move to GitHub-hosted images; the release workflow is trimmed to manual stable releases (no tag push, nightly cron, npm publish, Vercel deploy, Discord, or Windows/signing paths). Releases build macOS/Linux desktop artifacts and attach a t3 CLI .tgz from a new cli pack command instead of publishing to npm. Desktop remote SSH installs t3 from GitHub Release tarball URLs when repository.url points at the fork.

Product defaults and branding: Stage label Alpha → Bscholar across desktop/web; default auto-bootstrap and text-generation provider shift from Codex to Claude. Telemetry defaults to off. Composer/model UI keys trait options by provider instance id and limits the model picker sidebar to ready instances.

Some server tests around OTLP proxying and live CLI-over-running-server are removed or narrowed.

^{Reviewed by Cursor Bugbot for commit 9678427. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add Pi Agent provider with RPC adapter, text generation, and settings integration

• Introduces the piAgent provider driver (PiDriver.ts, PiAdapter.ts) that manages Pi Agent sessions, turns, and UI interactions via the @earendil-works/pi-coding-agent package.
• Adds PiTextGeneration (PiTextGeneration.ts) that spawns the Pi CLI with a 180s timeout, collects JSON output, and validates it against a schema.
• Registers piAgent in contracts (model.ts, settings.ts), provider registry, and UI metadata, with default models claude-sonnet-4-6 and claude-haiku-4-5.
• Switches auto-bootstrap and default text generation from Codex to Claude (claudeAgent/claude-haiku-4-5).
• Renames the app stage label from Alpha to Bscholar across desktop, web, and contracts.
• Overhauls the release workflow to require manual dispatch, drop nightly/Windows/macOS-x64 paths, and publish CLI tarballs via GitHub Releases.
• Risk: default provider change from Codex to Claude affects all fresh installs and auto-bootstrapped configurations.

📊 Macroscope summarized 9678427. 35 files reviewed, 6 issues evaluated, 0 issues filtered, 5 comments posted

🗂️ Filtered Issues

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 89cb2b1f-0e52-4dfd-83c3-6ac95848c5d1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes and found 7 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 9678427. Configure here.}

[cursor]

Alpha userData not migrated

High Severity

The legacyUserDataDirName was updated from "T3 Code (Alpha)" to "T3 Code (Bscholar)". This prevents resolveUserDataPath from finding existing user data in "Alpha" directories, causing a fresh user profile to be created and prior settings, SSH config, and Electron data to be lost on upgrade.

 

^{Reviewed by Cursor Bugbot for commit 9678427. Configure here.}

[cursor]

Pi launchArgs never applied

Medium Severity

The PiAdapter's startSession function omits PiSettings.launchArgs when spawning the Pi RPC process. This prevents user-configured arguments from being applied, unlike other drivers that support these settings.

 

^{Reviewed by Cursor Bugbot for commit 9678427. Configure here.}

[cursor]

Pi turns ignore attachments

Medium Severity

The sendTurn implementation only forwards the string input to Pi's prompt RPC, completely ignoring any attachments from ProviderSendTurnInput. This results in Pi receiving incomplete prompts when users include images or files.

 

^{Reviewed by Cursor Bugbot for commit 9678427. Configure here.}

[cursor]

Prerelease versions marked latest

Medium Severity

The release_meta step now always sets is_prerelease to false and make_latest to true. This means any version provided with a pre-release suffix (e.g., 1.2.3-beta.1) will be incorrectly published and promoted as the latest stable GitHub release.

 

^{Reviewed by Cursor Bugbot for commit 9678427. Configure here.}

[cursor]

Tests enable Pi probing

Low Severity

Several registry tests disable Codex, Claude, Cursor, and OpenCode probes to avoid spawning on CI, but set piAgent.enabled: true, which still runs the Pi --version health check. That breaks the stated isolation and can add flaky PATH-dependent behavior to Codex-focused cases.

Additional Locations (1)

• apps/server/src/provider/Layers/ProviderRegistry.test.ts#L1096-L1103

 

^{Reviewed by Cursor Bugbot for commit 9678427. Configure here.}

[cursor]

Inflight Pi turn marked completed

Medium Severity

If sendTurn is called while a Pi turn is still active, the adapter calls completeTurn with state completed before sending the new prompt. The Pi agent may still be running the previous work, so the UI can close a turn prematurely while RPC work continues.

 

^{Reviewed by Cursor Bugbot for commit 9678427. Configure here.}

[cursor]

Mac updater blockmaps not published

Medium Severity

The release job still collects *.blockmap files into artifacts but the GitHub release upload lists no longer include release-assets/*.blockmap. Mac builds that rely on electron-updater blockmaps may fail or fall back when updating from the published release.

Additional Locations (1)

• .github/workflows/release.yml#L237-L243

 

^{Reviewed by Cursor Bugbot for commit 9678427. Configure here.}

[macroscopeapp]

🟢 Low Layers/PiAdapter.ts:838

The pendingRequests entry for stateReqId is never cleaned up when Deferred.await times out at lines 838-840. If the 5-second timeout fires, the map entry remains orphaned until the session closes, leaking one entry per timed-out session startup. Consider deleting the entry on timeout using Effect.tap or Effect.ensuring.

     const stateResponse = yield* Deferred.await(stateDeferred).pipe(
       Effect.timeoutOption(5000),
+      Effect.tap(() => Effect.sync(() => pendingRequests.delete(stateReqId))),
     );

🤖 Copy this AI Prompt to have your agent fix this:

In file apps/server/src/provider/Layers/PiAdapter.ts around lines 838-840:

The `pendingRequests` entry for `stateReqId` is never cleaned up when `Deferred.await` times out at lines 838-840. If the 5-second timeout fires, the map entry remains orphaned until the session closes, leaking one entry per timed-out session startup. Consider deleting the entry on timeout using `Effect.tap` or `Effect.ensuring`.

Evidence trail:
apps/server/src/provider/Layers/PiAdapter.ts line 835: `pendingRequests.set(stateReqId, stateDeferred)` — entry added. Lines 838-840: `Deferred.await(stateDeferred).pipe(Effect.timeoutOption(5000))` — timeout does not delete entry. Line 598: `context.pendingRequests.delete(msg['id'])` — only deletion path, requires a response to arrive. Lines 613-665 (`stopSessionInternal`): `pendingExtensionUIs` explicitly cleaned at 625-631 with `.clear()`, but no cleanup for `pendingRequests` at all. Line 664: `sessions.delete(context.session.threadId)` removes context reference (GC-eligible), but entry persists in map until that point.

[macroscopeapp]

🟠 High workflows/release.yml:191

bun run build --filter=t3 passes --filter=t3 to the build script instead of interpreting it as a workspace filter. Bun requires top-level flags before subcommands, so the filter is ignored and the build may fail or run against the wrong packages. Use bun --filter=t3 run build to ensure the filter is applied.

Suggested change

	run: bun run build --filter=t3
	- name: Build t3 server package
	run: bun --filter=t3 run build

🤖 Copy this AI Prompt to have your agent fix this:

In file .github/workflows/release.yml around line 191:

`bun run build --filter=t3` passes `--filter=t3` to the build script instead of interpreting it as a workspace filter. Bun requires top-level flags before subcommands, so the filter is ignored and the build may fail or run against the wrong packages. Use `bun --filter=t3 run build` to ensure the filter is applied.

[macroscopeapp]

🟠 High workflows/release.yml:59

The version validation regex on line 55 accepts pre-release suffixes like -beta.1, but lines 64-65 unconditionally set is_prerelease=false and make_latest=true. When a user dispatches the workflow with version 1.2.3-beta.1, the GitHub Release is published as the latest stable release, directing all users to a pre-release build instead of respecting the pre-release semantics.

🤖 Copy this AI Prompt to have your agent fix this:

In file .github/workflows/release.yml around line 59:

The version validation regex on line 55 accepts pre-release suffixes like `-beta.1`, but lines 64-65 unconditionally set `is_prerelease=false` and `make_latest=true`. When a user dispatches the workflow with version `1.2.3-beta.1`, the GitHub Release is published as the latest stable release, directing all users to a pre-release build instead of respecting the pre-release semantics.

[macroscopeapp]

🟠 High web/index.html:92

The <title> was changed to T3 Code (Bscholar), where "Bscholar" appears to be the PR author's username rather than an intentional product stage name. This displays a personal identifier to all users in browser tabs, bookmarks, and search results. Consider reverting to a stage name like (Alpha) or confirming if this change is intentional.

🤖 Copy this AI Prompt to have your agent fix this:

In file apps/web/index.html around line 92:

The `<title>` was changed to `T3 Code (Bscholar)`, where "Bscholar" appears to be the PR author's username rather than an intentional product stage name. This displays a personal identifier to all users in browser tabs, bookmarks, and search results. Consider reverting to a stage name like `(Alpha)` or confirming if this change is intentional.

[macroscopeapp]

🟡 Medium

t3code/packages/contracts/src/settings.ts

Line 505 in 9678427

providers: Schema.optionalKey(

Adding piAgent to ServerSettings.providers at line 416 without a corresponding entry in ServerSettingsPatch.providers breaks the patch API for Pi settings. When users attempt to modify Pi settings, the request will fail validation because piAgent is missing from the patch struct at lines 505-511. Every other provider has a matching patch schema, so piAgent should have one too.

🤖 Copy this AI Prompt to have your agent fix this:

In file packages/contracts/src/settings.ts around line 505:

Adding `piAgent` to `ServerSettings.providers` at line 416 without a corresponding entry in `ServerSettingsPatch.providers` breaks the patch API for Pi settings. When users attempt to modify Pi settings, the request will fail validation because `piAgent` is missing from the patch struct at lines 505-511. Every other provider has a matching patch schema, so `piAgent` should have one too.

Evidence trail:
packages/contracts/src/settings.ts lines 411-417 (ServerSettings.providers includes piAgent), lines 505-511 (ServerSettingsPatch.providers omits piAgent), lines 461-490 (CodexSettingsPatch, ClaudeSettingsPatch, CursorSettingsPatch, OpenCodeSettingsPatch all defined, no PiSettingsPatch). PI_PLAN.md line 110 and 125 mention PiSettingsPatch only in a planning doc.

[macroscopeapp]

Approvability

Verdict: Needs human review

4 blocking correctness issues found. This PR introduces a new Pi Agent provider integration alongside major CI/CD workflow changes, branding modifications, and default behavior changes. Multiple high-severity unresolved comments identify potential data loss, broken release semantics, and questionable branding changes that require human assessment.

^{You can customize Macroscope's approvability policy. Learn more.}