fix(settings): validate the add-provider wizard step before advancing (#2813)

[leorivastech]

Fixes #2813.

In the "Add provider instance" dialog, the Next button moved you to the next
step without checking anything. So if you leave the Instance ID empty (or
invalid) on the Identity step and click Next, the wizard happily advances — and
you only find out at the very end, where "Add instance" silently does nothing.
From the user's side it looks like a dead button with no explanation.

The fix gates advancing on the current step. The Identity step now refuses to
advance while the Instance ID is invalid and surfaces the inline error that
already exists — the same check "Add instance" applies before submitting. Steps
that don't own the Instance ID are unaffected, and once the id is valid Next
works as before.

I pulled the navigation decision into a small pure function
(advanceInstanceWizard) so the rule is testable on its own, matching how
validateInstanceId is already structured in this file. Added unit tests covering:
leaving the Driver step with an invalid id (allowed), being blocked on the
Identity step with an invalid id, advancing once it's valid, and not advancing
past the last step. typecheck, lint and formatting are clean.

Happy to add a short before/after screen recording if that helps.

---

Note

Low Risk
Settings UI-only validation and navigation refactor with no server or persistence changes beyond existing save checks.

Overview
Add provider instance wizard no longer advances past Identity with an invalid instance ID. Next and clicking the Config step header both go through shared resolveWizardNavigation logic; blocked moves stay on Identity and flip hasAttemptedSubmit so the existing inline error shows. Driver → Identity and backward navigation are unchanged.

Wizard step labels move into AddProviderInstanceWizardSteps, with aria-current="step" on the active step. Step list and navigation rules live in AddProviderInstanceDialog.logic.ts with unit tests for block/skip/advance/clamp behavior.

^{Reviewed by Cursor Bugbot for commit 9f399ae. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Validate the add-provider wizard Identity step before advancing to Config

• Introduces resolveWizardNavigation in AddProviderInstanceDialog.logic.ts to determine whether wizard navigation should proceed or be blocked based on instance id validation when moving past the Identity step.
• Extracts step header rendering into a new AddProviderInstanceWizardSteps.tsx component that delegates click events through resolveWizardNavigation, reflecting step state via aria-current and check icons.
• Updates AddProviderInstanceDialog.tsx so the Next button and step header clicks both call applyWizardNavigation, which sets hasAttemptedSubmit on a blocked result to surface the inline validation error.
• Behavioral Change: clicking Next or a later step header while the instance id is invalid now redirects to the Identity step instead of advancing.

^{Macroscope summarized 9f399ae.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 146fd24d-d60e-4084-ad71-d3406e78fd54

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved

This is a straightforward bug fix that adds wizard step validation, preventing advancement when instance ID is invalid. The changes are self-contained to settings UI with comprehensive test coverage, and the commit author is the original file maintainer.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 9f399ae