Skip to content

fix(mobile): bump react-native-shiki-engine to 0.3.12 #3120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 4 commits into from
Jun 18, 2026
+372 −355
Merged

fix(mobile): bump react-native-shiki-engine to 0.3.12 #3120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e36b663
fix(mobile): bump react-native-shiki-engine to 0.3.12
skiniks Jun 17, 2026
cc296c5
feat(mobile): upgrade shiki packages to 4.2.0
skiniks Jun 17, 2026
481d2d7
chore(deps): upgrade @pierre/diffs to 1.3.0-beta.5
skiniks Jun 17, 2026
ef62f5d
chore(deps): remove patch for @pierre/diffs@1.3.0-beta.4
skiniks Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions apps/mobile/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@
"@noble/hashes": "catalog:",
"@pierre/diffs": "catalog:",
"@react-native-menu/menu": "^2.0.0",
"@shikijs/core": "3.23.0",
"@shikijs/engine-javascript": "3.23.0",
"@shikijs/langs": "3.23.0",
"@shikijs/themes": "3.23.0",
"@shikijs/core": "4.2.0",
"@shikijs/engine-javascript": "4.2.0",
"@shikijs/langs": "4.2.0",
"@shikijs/themes": "4.2.0",
"@t3tools/client-runtime": "workspace:*",
"@t3tools/contracts": "workspace:*",
"@t3tools/mobile-markdown-text": "file:./modules/t3-markdown-text",
Expand Down Expand Up @@ -98,10 +98,10 @@
"react-native-reanimated": "4.3.1",
"react-native-safe-area-context": "~5.7.0",
"react-native-screens": "4.25.2",
"react-native-shiki-engine": "^0.3.9",
"react-native-shiki-engine": "^0.3.12",
"react-native-svg": "15.15.4",
"react-native-worklets": "0.8.3",
"shiki": "3.23.0",
"shiki": "4.2.0",
"tailwind-merge": "^3.5.0",
"uniwind": "^1.6.2"
},
Expand Down
20 changes: 9 additions & 11 deletions patches/@pierre%2Fdiffs@1.3.0-beta.4.patch → patches/@pierre%2Fdiffs@1.3.0-beta.5.patch
View file
Open in desktop

@juliusmarminge juliusmarminge Jun 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete now unused beta.4 patch?

@skiniks skiniks Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set on that!

Original file line number Diff line number Diff line change
@@ -1,28 +1,26 @@
diff --git a/dist/editor/editor.js b/dist/editor/editor.js
index 4346c77a4e43a98c8524ea5186559fdee7433174..bb2a7ecd1d7f497916a5f220215d5191b095575b 100644
index e8013fc6eb6f243a6c912facf3fc0319ac66a8d0..80c82df4cdeb828bd331f5ec2f443d216bedc304 100644
--- a/dist/editor/editor.js
+++ b/dist/editor/editor.js
@@ -77,16 +77,13 @@ var Editor = class {
@@ -77,15 +77,12 @@ var Editor = class {
this.#options = options;
}
edit(component) {
- const { useTokenTransformer, enableGutterUtility, enableLineSelection, expandUnchanged, diffStyle, lineHoverHighlight,...rest } = component.options;
- if (useTokenTransformer !== true || enableGutterUtility === true || enableLineSelection === true || expandUnchanged !== true && Object.hasOwn(component, "fileDiff") || diffStyle === "unified" || lineHoverHighlight !== "disabled") {
+ const { useTokenTransformer, expandUnchanged, diffStyle,...rest } = component.options;
+ if (useTokenTransformer !== true || expandUnchanged !== true && Object.hasOwn(component, "fileDiff") || diffStyle === "unified") {
const isDiff = component.type === "file-diff";
- if (useTokenTransformer !== true || enableGutterUtility === true || enableLineSelection === true || lineHoverHighlight !== "disabled" || expandUnchanged !== true && isDiff || diffStyle === "unified" && isDiff) {
+ if (useTokenTransformer !== true || expandUnchanged !== true && isDiff || diffStyle === "unified" && isDiff) {
component.setOptions({
...rest,
useTokenTransformer: true,
- enableGutterUtility: false,
- enableLineSelection: false,
- lineHoverHighlight: "disabled",
expandUnchanged: true,
- diffStyle: "split",
- lineHoverHighlight: "disabled"
+ diffStyle: "split"
diffStyle: "split"
});
component.rerender();
}
@@ -481,6 +478,7 @@ var Editor = class {
@@ -511,6 +508,7 @@ var Editor = class {
return lineNumber - 1;
};
this.#editorEventDisposes.push(addEventListener(gutterEl, "pointerdown", (e) => {
Expand All @@ -47,7 +45,7 @@ index cb8e2026fb5d7a19f489c0a2402efbcb7dff3322..510fad6364d4a2214c7dd65fe2b114f1
return merged;
}
diff --git a/package.json b/package.json
index cff9c6b2a955e7568f44279a5b706da164c4f142..3d1f25f8bd1be682549677718d9ed8433872c854 100644
index d1558633de87044b7aa96cff09443db11f163cec..c0b16f0a0bec6fba2026f24f38b2c0a8fa06af7c 100644
--- a/package.json
+++ b/package.json
@@ -55,6 +55,18 @@
Expand Down
Loading
Loading