[codex] Close right panel when its last tab closes - #3221
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
juliusmarminge
marked this pull request as ready for review
June 20, 2026 06:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Surface-removal actions cleared
activeSurfaceIdbut leftisOpenset totrue, which rendered an empty right panel after the last tab closed.User impact
Closing the last tab now dismisses the right panel instead of leaving an empty panel visible.
Validation
vp test apps/web/src/rightPanelStore.test.ts(26 tests)vp checkvp run typecheckNote
Close the right panel when its last tab or surface is removed
Previously, the right panel stayed open even after all surfaces or terminal panes were closed. Three handlers in rightPanelStore.ts are updated to set
isOpentofalsewhen no surfaces remain:closeTerminal,closeSurface, andcloseAllSurfaces. Behavioral Change: the right panel now auto-closes when emptied, whereas before it remained open with no content.Macroscope summarized 7295f63.
Note
Low Risk
Localized UI state in the right-panel Zustand store with updated unit tests; no auth, data, or API changes.
Overview
Fixes a bug where closing the last right-panel tab left an empty panel visible because
isOpenstayedtrueafter surfaces were cleared.closeTerminal(when the final pane removes the surface),closeSurface, andcloseAllSurfacesinrightPanelStore.tsnow setisOpentofalsewhen no surfaces remain (surfaces.length === 0). Closing a non-active surface also applies the same rule so the panel does not stay open after the last tab is gone. Neighboring-tab activation when other surfaces remain is unchanged.Tests in
rightPanelStore.test.tsexpectisOpen: falsefor the last terminal pane, last surface, and close-all flows.Reviewed by Cursor Bugbot for commit 7295f63. Bugbot is set up for automated code reviews on this repo. Configure here.