Skip to content

[fix/feat:ui] Use shared button for model favorites#3223

Merged
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
sandersonstabo:sanderson/fix-ui-model-picker-favorite-button
Jun 20, 2026
Merged

[fix/feat:ui] Use shared button for model favorites#3223
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
sandersonstabo:sanderson/fix-ui-model-picker-favorite-button

Conversation

@sandersonstabo

@sandersonstabo sandersonstabo commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

What changed

The model picker favorite action now uses the shared Button component with variant="ghost" and icon sizing, as the previous had improper padding and was using its own button style compared to the rest of the app.

Why

This keeps the favorite control aligned with the rest of the compact icon buttons in the picker.

UI changes

Before:

Before

After:

After

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Testing

vp check; vp run typecheck passed locally before splitting these PRs.

Note

Replace native button with shared Button component for model favorites toggle

Swaps the hand-rolled native <button> in ModelListRow.tsx for the shared Button component with size="icon-xs" and variant="ghost". Hover styling changes as a result — background-related classes are removed and transitions now cover only color and opacity.

Macroscope summarized 36cf742.


Note

Low Risk
Localized UI-only change in the model picker with no logic or data-path impact.

Overview
The model picker favorite star in ModelListRow now uses the shared Button with size="icon-xs" and variant="ghost" instead of a custom native <button>.

Custom padding, sizing, and hover background classes are dropped in favor of the shared icon button styles. Row-specific classes still handle muted/opacity behavior and the filled star when favorited. Click, keyboard, disabled, and aria behavior is unchanged.

Reviewed by Cursor Bugbot for commit 36cf742. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 34b23a3d-e68d-42df-b866-ebb22b1d459f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Jun 20, 2026
@juliusmarminge
juliusmarminge marked this pull request as ready for review June 20, 2026 07:40
@juliusmarminge
juliusmarminge merged commit 6c5fb79 into pingdotgg:main Jun 20, 2026
21 checks passed
@macroscopeapp

macroscopeapp Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

This is a simple UI refactor replacing a raw HTML button with the shared Button component for styling consistency. The change is purely presentational with no behavior modifications.

You can customize Macroscope's approvability policy. Learn more.

ronak-guliani pushed a commit to ronak-guliani/t3code that referenced this pull request Jul 17, 2026
ronak-guliani added a commit to ronak-guliani/t3code that referenced this pull request Jul 19, 2026
* fix: stabilize composer typing state

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix truncated chat error alert layout (pingdotgg#3899)

* [fix/feat:ui] Use shared button for model favorites (pingdotgg#3223)

* [fix/feat:ui] Fix clipped chatbar provider badge (pingdotgg#3224)

* perf(web): duty-cycle status chrome animations

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* test(web): cover IME composer input

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Jake Leventhal <jakeleventhal@me.com>
Co-authored-by: ss <69873514+sandersonstabo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants