[fix/feat:ui] Use shared button for model favorites#3223
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved This is a simple UI refactor replacing a raw HTML button with the shared Button component for styling consistency. The change is purely presentational with no behavior modifications. You can customize Macroscope's approvability policy. Learn more. |
* fix: stabilize composer typing state Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix truncated chat error alert layout (pingdotgg#3899) * [fix/feat:ui] Use shared button for model favorites (pingdotgg#3223) * [fix/feat:ui] Fix clipped chatbar provider badge (pingdotgg#3224) * perf(web): duty-cycle status chrome animations Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * test(web): cover IME composer input Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jake Leventhal <jakeleventhal@me.com> Co-authored-by: ss <69873514+sandersonstabo@users.noreply.github.com>
What changed
The model picker favorite action now uses the shared Button component with
variant="ghost"and icon sizing, as the previous had improper padding and was using its own button style compared to the rest of the app.Why
This keeps the favorite control aligned with the rest of the compact icon buttons in the picker.
UI changes
Before:
After:
Checklist
Testing
vp check;vp run typecheckpassed locally before splitting these PRs.Note
Replace native button with shared
Buttoncomponent for model favorites toggleSwaps the hand-rolled native
<button>in ModelListRow.tsx for the sharedButtoncomponent withsize="icon-xs"andvariant="ghost". Hover styling changes as a result — background-related classes are removed and transitions now cover only color and opacity.Macroscope summarized 36cf742.
Note
Low Risk
Localized UI-only change in the model picker with no logic or data-path impact.
Overview
The model picker favorite star in
ModelListRownow uses the sharedButtonwithsize="icon-xs"andvariant="ghost"instead of a custom native<button>.Custom padding, sizing, and hover background classes are dropped in favor of the shared icon button styles. Row-specific classes still handle muted/opacity behavior and the filled star when favorited. Click, keyboard, disabled, and aria behavior is unchanged.
Reviewed by Cursor Bugbot for commit 36cf742. Bugbot is set up for automated code reviews on this repo. Configure here.