[codex] Structure Tailscale command failures

[juliusmarminge]

Summary

• replace the generic Tailscale command error with distinct Schema errors for spawn, output, exit, and timeout failures
• preserve exact process and timeout causes with tagged catch semantics
• retain only fixed executable/subcommand identity, argument count, exit code, timeout, and output lengths so auth keys and command output cannot enter direct error fields or messages

Validation

• vp test packages/tailscale/src/tailscale.test.ts (12 tests)
• vp check
• vp run typecheck

Note

Structure Tailscale command failures into typed error classes with sanitized context

• Replaces the generic TailscaleCommandError helper with four distinct Schema.TaggedErrorClass types: TailscaleCommandSpawnError, TailscaleCommandOutputError, TailscaleCommandExitError, and TailscaleCommandTimeoutError, each carrying structured context (executable, subcommand, argument count, and relevant metrics).
• Exit errors expose only stdoutLength/stderrLength instead of raw stdio content, and timeout errors include timeoutMs derived from the Duration input.
• TailscaleStatusParseError is also migrated to Schema.TaggedErrorClass with a fixed message and a Defect cause, avoiding raw error text in the message.
• Behavioral Change: error messages and types surfaced by readTailscaleStatus, ensureTailscaleServe, and disableTailscaleServe all change; callers relying on the previous error shape or message strings will break.

^{Macroscope summarized 1db0e32.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a8d2787c-dbc8-4318-8b51-4e09a5ac0562

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/tailscale-command-errors

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

Refactor that restructures Tailscale command error types into specific classes while keeping identical control flow. Includes security improvement by excluding sensitive data (stderr, auth tokens) from error messages. Well-tested with comprehensive new test cases.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 311e609

Dismissing prior approval to re-evaluate 1db0e32